Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2151693006: Add "builder_name" key to example_full_results_json (Closed)

Created:
4 years, 5 months ago by dcampb
Modified:
4 years, 5 months ago
Reviewers:
qyearsley, raikiri
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "builder_name" key to example_full_results_json Need for unit testing regarding http://crrev.com/2136723002 Committed: https://crrev.com/a771ea855832598ebd94e5d0faa09080687dadbf Cr-Commit-Position: refs/heads/master@{#405634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcampb
4 years, 5 months ago (2016-07-14 22:27:57 UTC) #2
raikiri
lgtm
4 years, 5 months ago (2016-07-14 22:28:38 UTC) #3
qyearsley
On 2016/07/14 at 22:28:38, raikiri wrote: > lgtm LGTM; before committing could you also clean ...
4 years, 5 months ago (2016-07-14 22:31:09 UTC) #4
dcampb
4 years, 5 months ago (2016-07-14 22:33:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151693006/1
4 years, 5 months ago (2016-07-14 22:34:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 23:49:23 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:51:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a771ea855832598ebd94e5d0faa09080687dadbf
Cr-Commit-Position: refs/heads/master@{#405634}

Powered by Google App Engine
This is Rietveld 408576698