Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2151673003: Only create the GPUTracer outputer when actually tracing (Closed)

Created:
4 years, 5 months ago by piman
Modified:
4 years, 5 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only create the GPUTracer outputer when actually tracing Creating the outputter needs to create and join a thread, which is quite costly. This is to speed up the GPU fuzzer, which recreates a decoder (hence a GPUTracer) for every test case. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1146887683dd7092beedd535e14168cad580161d Cr-Commit-Position: refs/heads/master@{#405561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gpu/command_buffer/service/gpu_tracer.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
piman
4 years, 5 months ago (2016-07-14 04:32:07 UTC) #5
no sievers
lgtm
4 years, 5 months ago (2016-07-14 20:39:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151673003/1
4 years, 5 months ago (2016-07-14 20:40:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 20:46:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:49:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1146887683dd7092beedd535e14168cad580161d
Cr-Commit-Position: refs/heads/master@{#405561}

Powered by Google App Engine
This is Rietveld 408576698