Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2151663003: [simulator] Check for C stack overflows during Invoke (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simulator] Check for C stack overflows during Invoke Simulators use separate stacks for C++ and JS. JS stack overflow checks are performed whenever a JS function is called. However, it can be the case that the C++ stack grows faster than the JS stack, resulting in an overflow there. Add a check here to make that less likely. BUG=chromium:604376 R=bmeurer@chromium.org, yangguo@chromium.org Committed: https://crrev.com/0b3e6843331fd216cc7b564137b67e9876fab90f Cr-Commit-Position: refs/heads/master@{#37749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/execution.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benedikt Meurer
Thanks, LGTM.
4 years, 5 months ago (2016-07-14 08:02:14 UTC) #4
Yang
On 2016/07/14 08:02:14, Benedikt Meurer wrote: > Thanks, LGTM. lgtm.
4 years, 5 months ago (2016-07-14 08:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151663003/1
4 years, 5 months ago (2016-07-14 08:47:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 08:54:18 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 08:56:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b3e6843331fd216cc7b564137b67e9876fab90f
Cr-Commit-Position: refs/heads/master@{#37749}

Powered by Google App Engine
This is Rietveld 408576698