third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index 21471d7924f7a6ca14ebe64eaa8873000ce5ac8c..281bb624d465530f52979af2c29dd484a49c87e4 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -82,7 +82,7 @@ WebInspector.TimelineTreeView.prototype = {

/**

* @param {!RuntimeAgent.CallFrame} frame

- * @return {!Element}

+ * @return {?Element}

linkifyLocation: function(frame)

{

@@ -347,7 +347,9 @@ WebInspector.TimelineTreeView.GridNode.prototype = {

var frame = WebInspector.TimelineProfileTree.eventStackFrame(event);

if (frame && frame["url"]) {

var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (frame);

- container.createChild("div", "activity-link").appendChild(this._treeView.linkifyLocation(callFrame));

+ var link = this._treeView.linkifyLocation(callFrame);

+ if (link)

+ container.createChild("div", "activity-link").appendChild(link);

}

icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor(event);

}