third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js - Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

index f1774126b7de0b574f5343ea7e5abd233159eb7d..26eaf4331c8df29c1ff437f607f09e8500416d65 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

@@ -308,7 +308,7 @@ WebInspector.HeapProfileView.NodeFormatter.prototype = {

/**

* @override

* @param {!WebInspector.ProfileDataGridNode} node

- * @return {!Element}

+ * @return {?Element}

linkifyNode: function(node)

{

@@ -432,9 +432,10 @@ WebInspector.HeapFlameChartDataProvider.prototype = {

pushEntryInfoRow(WebInspector.UIString("Self size"), Number.bytesToString(node.self));

pushEntryInfoRow(WebInspector.UIString("Total size"), Number.bytesToString(node.total));

var linkifier = new WebInspector.Linkifier();

- var text = (new WebInspector.Linkifier()).linkifyConsoleCallFrame(this._target, node.callFrame).textContent;

+ var link = linkifier.linkifyConsoleCallFrame(this._target, node.callFrame);

+ if (link)

+ pushEntryInfoRow(WebInspector.UIString("URL"), link.textContent);

linkifier.dispose();

- pushEntryInfoRow(WebInspector.UIString("URL"), text);

return entryInfo;