third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js - Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

index 2e2a94bc634d7e85249a1bb9ae90c70bcc4e6bfa..7f6cad2a8966507870efa3c84f0727711b6666d3 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

@@ -236,8 +236,11 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ

for (var stackFrame of stackTrace.callFrames) {

var row = createElement("tr");

row.createChild("td", "function-name").textContent = WebInspector.beautifyFunctionName(stackFrame.functionName);

- row.createChild("td").textContent = " @ ";

- row.createChild("td").appendChild(linkifier.linkifyConsoleCallFrame(target, stackFrame));

+ var link = linkifier.linkifyConsoleCallFrame(target, stackFrame);

+ if (link) {

+ row.createChild("td").textContent = " @ ";

dgozman 2016/07/16 20:34:39 I think it would still be useful to see "url:lineN

alph 2016/07/18 19:28:53 Agree. Done that in maybeLinkifyScriptLocation

+ row.createChild("td").appendChild(link);

+ }

contentElement.appendChild(row);

}