third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update a test expectation. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 6a5813dbb14a78d19e5298150134fd8f5bdbd3f7..29a6b68ce1af6d0268aecb36ee57205cc79be2a6 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -1066,10 +1066,12 @@ WebInspector.ObjectPropertiesSection.createValueElement = function(value, wasThr

if (type === "object" && subtype === "internal#location") {

var rawLocation = value.debuggerModel().createRawLocationByScriptId(value.value.scriptId, value.value.lineNumber, value.value.columnNumber);

- if (rawLocation && linkifier)

- return linkifier.linkifyRawLocation(rawLocation, "");

- else

- valueElement.textContent = "<unknown>";

+ if (rawLocation && linkifier) {

+ var anchor = linkifier.linkifyRawLocation(rawLocation, "");

+ if (anchor)

+ return anchor;

+ }

+ valueElement.textContent = "<unknown>";

}

function mouseMove()