DevTools: Do not linkify to pseudo (program) node when there's no URL

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 512 matching lines @@
 
 /**
  * @param {!WebInspector.TracingModel.Event} event
  * @param {?WebInspector.Target} target
  * @param {!WebInspector.Linkifier} linkifier
  * @return {?Node}
  */
 WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, target, linkifier)
 {
     var recordType = WebInspector.TimelineModel.RecordType;
-    var details;
+    var details = null;
     var detailsText;
     var eventData = event.args["data"];
     switch (event.name) {
     case recordType.GCEvent:
     case recordType.MajorGC:
     case recordType.MinorGC:
     case recordType.EventDispatch:
     case recordType.Paint:
     case recordType.Animation:
     case recordType.EmbedderCallback:
@@ skipping 53 matching lines @@
 
     if (!details && detailsText)
         details = createTextNode(detailsText);
     return details;
 
     /**
      * @param {string} scriptId
      * @param {string} url
      * @param {number} lineNumber
      * @param {number=} columnNumber
+     * @return {?Element}
      */
     function linkifyLocation(scriptId, url, lineNumber, columnNumber)
     {
         // FIXME(62725): stack trace line/column numbers are one-based.
         if (columnNumber)
             --columnNumber;
         return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber - 1, columnNumber, "timeline-details");
     }
 
     /**
      * @return {?Element}
      */
     function linkifyTopCallFrame()
     {
         var frame = WebInspector.TimelineUIUtils.topStackFrame(event);
-        return frame ? linkifier.linkifyConsoleCallFrameForTimeline(target, frame, "timeline-details") : null;
+        return frame ? linkifier.maybeLinkifyConsoleCallFrameForTimeline(target, frame, "timeline-details") : null;
     }
 }
 
 /**
  * @param {!WebInspector.TracingModel.Event} event
  * @param {!WebInspector.TimelineModel} model
  * @param {!WebInspector.Linkifier} linkifier
  * @param {boolean} detailed
  * @param {function(!DocumentFragment)} callback
  */
@@ skipping 356 matching lines @@
         var priority = WebInspector.uiLabelForPriority(/** @type {!NetworkAgent.ResourcePriority} */ (request.priority));
         contentHelper.appendTextRow(WebInspector.UIString("Priority"), priority);
     }
     if (request.mimeType)
         contentHelper.appendTextRow(WebInspector.UIString("Mime Type"), request.mimeType);
 
     var title = WebInspector.UIString("Initiator");
     var sendRequest = request.children[0];
     var topFrame = WebInspector.TimelineUIUtils.topStackFrame(sendRequest);
     if (topFrame) {
-        contentHelper.appendElementRow(title, linkifier.linkifyConsoleCallFrameForTimeline(target, topFrame));
+        var link = linkifier.maybeLinkifyConsoleCallFrameForTimeline(target, topFrame);
+        if (link)
+            contentHelper.appendElementRow(title, link);
     } else if (sendRequest.initiator) {
         var initiatorURL = WebInspector.TimelineUIUtils.eventURL(sendRequest.initiator);
-        if (initiatorURL)
-            contentHelper.appendElementRow(title, linkifier.linkifyScriptLocation(target, null, initiatorURL, 0));
+        if (initiatorURL) {
+            var link = linkifier.maybeLinkifyScriptLocation(target, null, initiatorURL, 0);
+            if (link)
+                contentHelper.appendElementRow(title, link);
+        }
     }
 
     /**
      * @param {function(?Element)} fulfill
      */
     function action(fulfill)
     {
         WebInspector.DOMPresentationUtils.buildImagePreviewContents(/** @type {!WebInspector.Target} */(target), request.url, false, saveImage);
         /**
          * @param {!Element=} element
@@ skipping 219 matching lines @@
             title.createTextChild(WebInspector.UIString("%s for ", reason));
         else
             title.createTextChild(WebInspector.UIString("Unknown cause for "));
 
         this._appendTruncatedNodeList(title, this._invalidations);
 
         if (topFrame && this._contentHelper.linkifier()) {
             title.createTextChild(WebInspector.UIString(". "));
             var stack = title.createChild("span", "monospace");
             stack.createChild("span").textContent = WebInspector.beautifyFunctionName(topFrame.functionName);
-            stack.createChild("span").textContent = " @ ";
-            stack.createChild("span").appendChild(this._contentHelper.linkifier().linkifyConsoleCallFrameForTimeline(target, topFrame));
+            var link = this._contentHelper.linkifier().maybeLinkifyConsoleCallFrameForTimeline(target, topFrame);
+            if (link) {
+                stack.createChild("span").textContent = " @ ";
+                stack.createChild("span").appendChild(link);
+            }
         }
 
         return title;
     },
 
     /**
      * @override
      */
     onpopulate: function()
     {
@@ skipping 789 matching lines @@
      * @param {string} url
      * @param {number} startLine
      * @param {number=} startColumn
      */
     appendLocationRow: function(title, url, startLine, startColumn)
     {
         if (!this._linkifier || !this._target)
             return;
         if (startColumn)
             --startColumn;
-        this.appendElementRow(title, this._linkifier.linkifyScriptLocation(this._target, null, url, startLine - 1, startColumn));
+        var link = this._linkifier.maybeLinkifyScriptLocation(this._target, null, url, startLine - 1, startColumn);
+        if (!link)
+            return;
+        this.appendElementRow(title, link);
     },
 
     /**
      * @param {string} title
      * @param {string} url
      * @param {number} startLine
      * @param {number=} endLine
      */
     appendLocationRange: function(title, url, startLine, endLine)
     {
         if (!this._linkifier || !this._target)
             return;
         var locationContent = createElement("span");
-        locationContent.appendChild(this._linkifier.linkifyScriptLocation(this._target, null, url, startLine - 1));
+        var link = this._linkifier.maybeLinkifyScriptLocation(this._target, null, url, startLine - 1);
+        if (!link)
+            return;
+        locationContent.appendChild(link);
         locationContent.createTextChild(String.sprintf(" [%s\u2026%s]", startLine, endLine || ""));
         this.appendElementRow(title, locationContent);
     },
 
     /**
      * @param {string} title
      * @param {!RuntimeAgent.StackTrace} stackTrace
      */
     appendStackTrace: function(title, stackTrace)
     {
@@ skipping 59 matching lines @@
     case warnings.V8Deopt:
         span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/GoogleChrome/devtools-docs/issues/53",
             WebInspector.UIString("Not optimized"), undefined, true));
         span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReason"]));
         break;
     default:
         console.assert(false, "Unhandled TimelineModel.WarningType");
     }
     return span;
 }