Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1050 matching lines...) Expand 10 before | Expand all | Expand 10 after
1061 valueElement.addEventListener("mousemove", mouseMove, false); 1061 valueElement.addEventListener("mousemove", mouseMove, false);
1062 valueElement.addEventListener("mouseleave", mouseLeave, false); 1062 valueElement.addEventListener("mouseleave", mouseLeave, false);
1063 } else { 1063 } else {
1064 valueElement.title = description || ""; 1064 valueElement.title = description || "";
1065 } 1065 }
1066 1066
1067 if (type === "object" && subtype === "internal#location") { 1067 if (type === "object" && subtype === "internal#location") {
1068 var rawLocation = value.debuggerModel().createRawLocationByScriptId(valu e.value.scriptId, value.value.lineNumber, value.value.columnNumber); 1068 var rawLocation = value.debuggerModel().createRawLocationByScriptId(valu e.value.scriptId, value.value.lineNumber, value.value.columnNumber);
1069 if (rawLocation && linkifier) 1069 if (rawLocation && linkifier)
1070 return linkifier.linkifyRawLocation(rawLocation, ""); 1070 return linkifier.linkifyRawLocation(rawLocation, "");
1071 else 1071 valueElement.textContent = "<unknown>";
1072 valueElement.textContent = "<unknown>";
1073 } 1072 }
1074 1073
1075 function mouseMove() 1074 function mouseMove()
1076 { 1075 {
1077 WebInspector.DOMModel.highlightObjectAsDOMNode(value); 1076 WebInspector.DOMModel.highlightObjectAsDOMNode(value);
1078 } 1077 }
1079 1078
1080 function mouseLeave() 1079 function mouseLeave()
1081 { 1080 {
1082 WebInspector.DOMModel.hideDOMNodeHighlight(); 1081 WebInspector.DOMModel.hideDOMNodeHighlight();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 1260
1262 result = currentName + (result ? "." + result : ""); 1261 result = currentName + (result ? "." + result : "");
1263 current = current.parent; 1262 current = current.parent;
1264 } 1263 }
1265 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId]; 1264 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId];
1266 result = treeOutlineId + (result ? ":" + result : ""); 1265 result = treeOutlineId + (result ? ":" + result : "");
1267 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result; 1266 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result;
1268 return result; 1267 return result;
1269 } 1268 }
1270 } 1269 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698