DevTools: Do not linkify to pseudo (program) node when there's no URL

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 142 matching lines @@
         }
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {?string} scriptId
      * @param {string} sourceURL
      * @param {number} lineNumber
      * @param {number=} columnNumber
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
-    linkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)
+    maybeLinkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)
     {
-        var fallbackAnchor = WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes);
+        var fallbackAnchor = sourceURL ? WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes) : null;
         if (!target || target.isDetached())
             return fallbackAnchor;
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
         if (!debuggerModel)
             return fallbackAnchor;
 
-        var rawLocation = scriptId ? debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber || 0) :
-                                     debuggerModel.createRawLocationByURL(sourceURL, lineNumber, columnNumber || 0);
+        var rawLocation = scriptId
+            ? debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber || 0)
+            : debuggerModel.createRawLocationByURL(sourceURL, lineNumber, columnNumber || 0);
         if (!rawLocation)
             return fallbackAnchor;
 
         var anchor = this._createAnchor(classes);
         var liveLocation = WebInspector.debuggerWorkspaceBinding.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor), /** @type {!WebInspector.LiveLocationPool} */(this._locationPoolByTarget.get(rawLocation.target())));
         var anchors = /** @type {!Array<!Element>} */(this._anchorsByTarget.get(rawLocation.target()));
         anchors.push(anchor);
         anchor[WebInspector.Linkifier._liveLocationSymbol] = liveLocation;
         anchor[WebInspector.Linkifier._fallbackAnchorSymbol] = fallbackAnchor;
         return anchor;
     },
 
     /**
+     * @param {?WebInspector.Target} target
+     * @param {?string} scriptId
+     * @param {string} sourceURL
+     * @param {number} lineNumber
+     * @param {number=} columnNumber
+     * @param {string=} classes
+     * @return {!Element}
+     */
+    linkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)
+    {
+        return this.maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes)
+            || WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes);
+    },
+
+    /**
      * @param {!WebInspector.DebuggerModel.Location} rawLocation
      * @param {string} fallbackUrl
      * @param {string=} classes
      * @return {!Element}
      */
     linkifyRawLocation: function(rawLocation, fallbackUrl, classes)
     {
         return this.linkifyScriptLocation(rawLocation.target(), rawLocation.scriptId, fallbackUrl, rawLocation.lineNumber, rawLocation.columnNumber, classes);
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {!RuntimeAgent.CallFrame} callFrame
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyConsoleCallFrame: function(target, callFrame, classes)

[dgozman, 2016/07/16 20:34:39]

maybeLinkify...

[alph, 2016/07/18 19:28:53]

Done.

     {
-        return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber, classes);
+        return this.maybeLinkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber, classes);
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {!RuntimeAgent.CallFrame} callFrame
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes)

[dgozman, 2016/07/16 20:34:39]

maybeLinkify...

[alph, 2016/07/18 19:28:54]

Done.

     {
         // TODO(kozyatinskiy): remove this when Profilers will migrate to 0-based lineNumber and columnNumber.
         return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);
     },
 
     /**
      * @param {!WebInspector.Target} target
      * @param {!RuntimeAgent.StackTrace} stackTrace
      * @param {string=} classes
      * @return {!Element}
@@ skipping 300 matching lines @@
  * @param {string} url
  * @param {number=} lineNumber
  * @param {number=} columnNumber
  * @param {string=} classes
  * @param {string=} tooltipText
  * @param {string=} urlDisplayName
  * @return {!Element}
  */
 WebInspector.linkifyResourceAsNode = function(url, lineNumber, columnNumber, classes, tooltipText, urlDisplayName)
 {
     var linkText = urlDisplayName ? urlDisplayName : url ? WebInspector.displayNameForURL(url) : WebInspector.UIString("(program)");

[dgozman, 2016/07/16 20:34:39]

Let's return empty element instead of "(program)"? Or just a span with
"url:lineNumber" text instead of a link. That was the initial goal of the patch,
right?

[alph, 2016/07/18 19:28:53]

Empty element would be weird, as some clients might still print something like
"foo @ link"
How about keep a static placeholder, e.g. (unknown).

     if (typeof lineNumber === "number")
         linkText += ":" + (lineNumber + 1);
     var anchor = WebInspector.linkifyURLAsNode(url, linkText, classes, false, tooltipText);
     anchor.lineNumber = lineNumber;
     anchor.columnNumber = columnNumber;
     return anchor;
 }
 
 /**
  * @param {!WebInspector.NetworkRequest} request
  * @return {!Element}
  */
 WebInspector.linkifyRequestAsNode = function(request)
 {
     var anchor = WebInspector.linkifyURLAsNode(request.url);
     anchor.requestId = request.requestId;
     return anchor;
 }