Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update a test expectation. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @implements {WebInspector.Searchable} 7 * @implements {WebInspector.Searchable}
8 * @extends {WebInspector.ProfileView} 8 * @extends {WebInspector.ProfileView}
9 * @param {!WebInspector.SamplingHeapProfileHeader} profileHeader 9 * @param {!WebInspector.SamplingHeapProfileHeader} profileHeader
10 */ 10 */
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 * @return {string} 301 * @return {string}
302 */ 302 */
303 formatPercent: function(value, node) 303 formatPercent: function(value, node)
304 { 304 {
305 return WebInspector.UIString("%.2f\u2009%%", value); 305 return WebInspector.UIString("%.2f\u2009%%", value);
306 }, 306 },
307 307
308 /** 308 /**
309 * @override 309 * @override
310 * @param {!WebInspector.ProfileDataGridNode} node 310 * @param {!WebInspector.ProfileDataGridNode} node
311 * @return {!Element} 311 * @return {?Element}
312 */ 312 */
313 linkifyNode: function(node) 313 linkifyNode: function(node)
314 { 314 {
315 return this._profileView.linkifier().linkifyConsoleCallFrame(this._profi leView.target(), node.profileNode.callFrame, "profile-node-file"); 315 return this._profileView.linkifier().linkifyConsoleCallFrame(this._profi leView.target(), node.profileNode.callFrame, "profile-node-file");
316 } 316 }
317 } 317 }
318 318
319 /** 319 /**
320 * @constructor 320 * @constructor
321 * @extends {WebInspector.ProfileFlameChartDataProvider} 321 * @extends {WebInspector.ProfileFlameChartDataProvider}
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 * @param {string} value 425 * @param {string} value
426 */ 426 */
427 function pushEntryInfoRow(title, value) 427 function pushEntryInfoRow(title, value)
428 { 428 {
429 entryInfo.push({ title: title, value: value }); 429 entryInfo.push({ title: title, value: value });
430 } 430 }
431 pushEntryInfoRow(WebInspector.UIString("Name"), WebInspector.beautifyFun ctionName(node.functionName)); 431 pushEntryInfoRow(WebInspector.UIString("Name"), WebInspector.beautifyFun ctionName(node.functionName));
432 pushEntryInfoRow(WebInspector.UIString("Self size"), Number.bytesToStrin g(node.self)); 432 pushEntryInfoRow(WebInspector.UIString("Self size"), Number.bytesToStrin g(node.self));
433 pushEntryInfoRow(WebInspector.UIString("Total size"), Number.bytesToStri ng(node.total)); 433 pushEntryInfoRow(WebInspector.UIString("Total size"), Number.bytesToStri ng(node.total));
434 var linkifier = new WebInspector.Linkifier(); 434 var linkifier = new WebInspector.Linkifier();
435 var text = (new WebInspector.Linkifier()).linkifyConsoleCallFrame(this._ target, node.callFrame).textContent; 435 var link = linkifier.linkifyConsoleCallFrame(this._target, node.callFram e);
436 if (link)
437 pushEntryInfoRow(WebInspector.UIString("URL"), link.textContent);
436 linkifier.dispose(); 438 linkifier.dispose();
437 pushEntryInfoRow(WebInspector.UIString("URL"), text);
438 return entryInfo; 439 return entryInfo;
439 }, 440 },
440 441
441 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype 442 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype
442 } 443 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698