DevTools: Do not linkify to pseudo (program) node when there's no URL

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 142 matching lines @@
         }
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {?string} scriptId
      * @param {string} sourceURL
      * @param {number} lineNumber
      * @param {number=} columnNumber
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)

[dgozman, 2016/07/15 23:24:22]

This is used in ConsoleViewMessage._tryFormatAsError,
NetworkDataGridNode._renderInitiatorCell,
HeapSnapshotView._didReceiveAllocationStack, AllocationGridNode.createCell and
ServiceWorkersView._addError.

     {
-        var fallbackAnchor = WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes);
+        var fallbackAnchor = sourceURL ? WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes) : null;
         if (!target || target.isDetached())
             return fallbackAnchor;
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
         if (!debuggerModel)
             return fallbackAnchor;
 
-        var rawLocation = scriptId ? debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber || 0) :
-                                     debuggerModel.createRawLocationByURL(sourceURL, lineNumber, columnNumber || 0);
+        var rawLocation = scriptId && scriptId !== "0"

[dgozman, 2016/07/15 23:24:22]

Let's rather fix backend to send empty string or better not send scriptId at
all.

+            ? debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber || 0)
+            : debuggerModel.createRawLocationByURL(sourceURL, lineNumber, columnNumber || 0);
         if (!rawLocation)
             return fallbackAnchor;
 
         var anchor = this._createAnchor(classes);
         var liveLocation = WebInspector.debuggerWorkspaceBinding.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor), /** @type {!WebInspector.LiveLocationPool} */(this._locationPoolByTarget.get(rawLocation.target())));
         var anchors = /** @type {!Array<!Element>} */(this._anchorsByTarget.get(rawLocation.target()));
         anchors.push(anchor);
         anchor[WebInspector.Linkifier._liveLocationSymbol] = liveLocation;
         anchor[WebInspector.Linkifier._fallbackAnchorSymbol] = fallbackAnchor;
         return anchor;
     },
 
     /**
      * @param {!WebInspector.DebuggerModel.Location} rawLocation
      * @param {string} fallbackUrl
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyRawLocation: function(rawLocation, fallbackUrl, classes)

[dgozman, 2016/07/15 23:24:22]

This is used in ObjectPopoverHelper._showObjectPopover.

     {
         return this.linkifyScriptLocation(rawLocation.target(), rawLocation.scriptId, fallbackUrl, rawLocation.lineNumber, rawLocation.columnNumber, classes);
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {!RuntimeAgent.CallFrame} callFrame
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyConsoleCallFrame: function(target, callFrame, classes)
     {
         return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber, classes);
     },
 
     /**
      * @param {?WebInspector.Target} target
      * @param {!RuntimeAgent.CallFrame} callFrame
      * @param {string=} classes
-     * @return {!Element}
+     * @return {?Element}
      */
     linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes)
     {
         // TODO(kozyatinskiy): remove this when Profilers will migrate to 0-based lineNumber and columnNumber.
         return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);
     },
 
     /**
      * @param {!WebInspector.Target} target
      * @param {!RuntimeAgent.StackTrace} stackTrace
@@ skipping 321 matching lines @@
 /**
  * @param {!WebInspector.NetworkRequest} request
  * @return {!Element}
  */
 WebInspector.linkifyRequestAsNode = function(request)
 {
     var anchor = WebInspector.linkifyURLAsNode(request.url);
     anchor.requestId = request.requestId;
     return anchor;
 }