Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update a test expectation. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 4 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
5 * Copyright (C) 2009 Joseph Pecoraro 5 * Copyright (C) 2009 Joseph Pecoraro
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 10 *
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 var contentElement = shadowRoot.createChild("table", "stack-preview-containe r"); 229 var contentElement = shadowRoot.createChild("table", "stack-preview-containe r");
230 230
231 /** 231 /**
232 * @param {!RuntimeAgent.StackTrace} stackTrace 232 * @param {!RuntimeAgent.StackTrace} stackTrace
233 */ 233 */
234 function appendStackTrace(stackTrace) 234 function appendStackTrace(stackTrace)
235 { 235 {
236 for (var stackFrame of stackTrace.callFrames) { 236 for (var stackFrame of stackTrace.callFrames) {
237 var row = createElement("tr"); 237 var row = createElement("tr");
238 row.createChild("td", "function-name").textContent = WebInspector.be autifyFunctionName(stackFrame.functionName); 238 row.createChild("td", "function-name").textContent = WebInspector.be autifyFunctionName(stackFrame.functionName);
239 row.createChild("td").textContent = " @ "; 239 var link = linkifier.linkifyConsoleCallFrame(target, stackFrame);
240 row.createChild("td").appendChild(linkifier.linkifyConsoleCallFrame( target, stackFrame)); 240 if (link) {
241 row.createChild("td").textContent = " @ ";
242 row.createChild("td").appendChild(link);
243 }
241 contentElement.appendChild(row); 244 contentElement.appendChild(row);
242 } 245 }
243 } 246 }
244 247
245 if (!stackTrace) 248 if (!stackTrace)
246 return element; 249 return element;
247 250
248 appendStackTrace(stackTrace); 251 appendStackTrace(stackTrace);
249 252
250 var asyncStackTrace = stackTrace.parent; 253 var asyncStackTrace = stackTrace.parent;
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 /** 656 /**
654 * @override 657 * @override
655 * @param {!WebInspector.DOMNode} node 658 * @param {!WebInspector.DOMNode} node
656 * @return {?{title: string, color: string}} 659 * @return {?{title: string, color: string}}
657 */ 660 */
658 decorate: function(node) 661 decorate: function(node)
659 { 662 {
660 return { title: this._title, color: this._color }; 663 return { title: this._title, color: this._color };
661 } 664 }
662 } 665 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698