Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2151653004: Fix a -Wunused-private-member warning in a //media/gpu file. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a -Wunused-private-member warning in a //media/gpu file. Building w/ clang on CrOS detected an unused private member in a CrOS-specific file in a particular combination of GN args :). R=posciak@chromium.org, llozano@chromium.org BUG=626240 Committed: https://crrev.com/f3d6584cfe2a5aa67ce3bfd688fd18217d1d066a Cr-Commit-Position: refs/heads/master@{#405960}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/use_libvl2_/use_libv4l2_/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M media/gpu/generic_v4l2_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/gpu/generic_v4l2_device.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Dirk Pranke
I think this is probably correct, but I haven't done a compile w/ the right ...
4 years, 5 months ago (2016-07-15 02:13:04 UTC) #1
Pawel Osciak
+wuchengli, +henryhsu, ptal
4 years, 5 months ago (2016-07-15 07:32:04 UTC) #5
llozano
I will verify tomorrow.
4 years, 5 months ago (2016-07-15 08:42:10 UTC) #6
wuchengli
https://codereview.chromium.org/2151653004/diff/1/media/gpu/generic_v4l2_device.cc File media/gpu/generic_v4l2_device.cc (right): https://codereview.chromium.org/2151653004/diff/1/media/gpu/generic_v4l2_device.cc#newcode53 media/gpu/generic_v4l2_device.cc:53: use_libvl2_ = false; s/use_libvl2_/use_libv4l2_/
4 years, 5 months ago (2016-07-15 13:16:06 UTC) #7
Dirk Pranke
https://codereview.chromium.org/2151653004/diff/1/media/gpu/generic_v4l2_device.cc File media/gpu/generic_v4l2_device.cc (right): https://codereview.chromium.org/2151653004/diff/1/media/gpu/generic_v4l2_device.cc#newcode53 media/gpu/generic_v4l2_device.cc:53: use_libvl2_ = false; On 2016/07/15 13:16:06, wuchengli wrote: > ...
4 years, 5 months ago (2016-07-15 19:10:07 UTC) #8
wuchengli
lgtm
4 years, 5 months ago (2016-07-17 03:21:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151653004/20001
4 years, 5 months ago (2016-07-17 22:13:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 00:41:37 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 00:41:39 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 00:45:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3d6584cfe2a5aa67ce3bfd688fd18217d1d066a
Cr-Commit-Position: refs/heads/master@{#405960}

Powered by Google App Engine
This is Rietveld 408576698