Issue 215163003: Fixing inadvertant CQ breakage from depot tools change.

Issue 215163003: Fixing inadvertant CQ breakage from depot tools change. (Closed)

Created:
6 years, 9 months ago by Sergey Berezin

Modified:
6 years, 9 months ago

Reviewers:
Ken Russell (switch to Gerrit), M-A Ruel, pgervais

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Ken Russell (switch to Gerrit), pgervais

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fixing inadvertant CQ breakage from depot tools change. CL that cause the issue: https://codereview.chromium.org/183793010 Symptoms: commit queue presubmit checks failed. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259947

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	rietveld.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Berezin

The CQ bit was checked by sergeyberezin@chromium.org

6 years, 9 months ago (2014-03-27 19:02:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/215163003/1

6 years, 9 months ago (2014-03-27 19:02:32 UTC) #4

Ken Russell (switch to Gerrit)

Thanks for fixing this. I would have referenced BUG=348233, but now that this CL is ...

6 years, 9 months ago (2014-03-27 19:06:26 UTC) #5

Sergey Berezin

6 years, 9 months ago (2014-03-27 19:11:49 UTC) #7

Message was sent while issue was closed.

On 2014/03/27 19:06:26, Ken Russell wrote:
> Thanks for fixing this. I would have referenced BUG=348233, but now that this
CL
> is in the commit queue, let's leave the description alone.
> 
> LGTM

No problem, thanks for catching it fast.
I think that bug doesn't actually have much to do with the problem, and may be
confusing. I'll leave the CL link as the direct reason in the description.

Expand Messages | Collapse Messages