Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: PRESUBMIT.py

Issue 2151623002: Specifying master names with "master." prefix is deprecated (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Top-level presubmit script for Skia. 6 """Top-level presubmit script for Skia.
7 7
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl. 9 for more details about the presubmit API built into gcl.
10 """ 10 """
(...skipping 23 matching lines...) Expand all
34 ) 34 )
35 35
36 AUTHORS_FILE_NAME = 'AUTHORS' 36 AUTHORS_FILE_NAME = 'AUTHORS'
37 37
38 DOCS_PREVIEW_URL = 'https://skia.org/?cl=' 38 DOCS_PREVIEW_URL = 'https://skia.org/?cl='
39 GOLD_TRYBOT_URL = 'https://gold.skia.org/search?issue=' 39 GOLD_TRYBOT_URL = 'https://gold.skia.org/search?issue='
40 40
41 # Path to CQ bots feature is described in https://bug.skia.org/4364 41 # Path to CQ bots feature is described in https://bug.skia.org/4364
42 PATH_PREFIX_TO_EXTRA_TRYBOTS = { 42 PATH_PREFIX_TO_EXTRA_TRYBOTS = {
43 # pylint: disable=line-too-long 43 # pylint: disable=line-too-long
44 'cmake/': 'client.skia.compile:Build-Mac-Clang-x86_64-Release-CMake-Trybot,B uild-Ubuntu-GCC-x86_64-Release-CMake-Trybot', 44 'cmake/': 'master.client.skia.compile:Build-Mac-Clang-x86_64-Release-CMake-T rybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot',
45 # pylint: disable=line-too-long 45 # pylint: disable=line-too-long
46 'src/opts/': 'client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_N O_SIMD-Trybot', 46 'src/opts/': 'master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release -SKNX_NO_SIMD-Trybot',
47 47
48 'include/private/SkAtomics.h': ('client.skia:' 48 'include/private/SkAtomics.h': ('master.client.skia:'
49 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,' 49 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,'
50 'Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot' 50 'Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot'
51 ), 51 ),
52 52
53 # Below are examples to show what is possible with this feature. 53 # Below are examples to show what is possible with this feature.
54 # 'src/svg/': 'master1:abc;master2:def', 54 # 'src/svg/': 'master1:abc;master2:def',
55 # 'src/svg/parser/': 'master3:ghi,jkl;master4:mno', 55 # 'src/svg/parser/': 'master3:ghi,jkl;master4:mno',
56 # 'src/image/SkImage_Base.h': 'master5:pqr,stu;master1:abc1;master2:def', 56 # 'src/image/SkImage_Base.h': 'master5:pqr,stu;master1:abc1;master2:def',
57 } 57 }
58 58
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 state and an error if it is in 'Closed' state. 516 state and an error if it is in 'Closed' state.
517 """ 517 """
518 results = [] 518 results = []
519 results.extend(_CommonChecks(input_api, output_api)) 519 results.extend(_CommonChecks(input_api, output_api))
520 results.extend( 520 results.extend(
521 _CheckTreeStatus(input_api, output_api, json_url=( 521 _CheckTreeStatus(input_api, output_api, json_url=(
522 SKIA_TREE_STATUS_URL + '/banner-status?format=json'))) 522 SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
523 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api)) 523 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
524 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api)) 524 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
525 return results 525 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698