Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2151613002: Revert "Hide web notification tray when LoginStatus is locked" (Closed)

Created:
4 years, 5 months ago by yoshiki
Modified:
4 years, 5 months ago
Reviewers:
Qiang(Joe) Xu
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Hide web notification tray when LoginStatus is locked" This reverts commit 198e264eb577cab76a6cb13d1d8b4b5d0135cb3c. The root cause of the crash has been fixed and we don't need this patch now. BUG=625357 TBR=warx@chromium.org Committed: https://crrev.com/4f78cb96761fe87d72220e08744a5c203c7f5a26 Cr-Commit-Position: refs/heads/master@{#405239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yoshiki
4 years, 5 months ago (2016-07-13 19:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151613002/20001
4 years, 5 months ago (2016-07-13 19:17:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-13 19:52:59 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:54:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:55:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f78cb96761fe87d72220e08744a5c203c7f5a26
Cr-Commit-Position: refs/heads/master@{#405239}

Powered by Google App Engine
This is Rietveld 408576698