Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2151603002: ash: Fix flaky TrayIME* tests. (Closed)

Created:
4 years, 5 months ago by sadrul
Modified:
4 years, 5 months ago
Reviewers:
James Cook, rsadam
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Fix flaky TrayIME* tests. It is necessary to restore the keyboard/touchscreen devices at the end of the tests, so that subsequent tests are not affected. BUG=545533 Committed: https://crrev.com/f26aa45a91493bb65a452ac671b66ed6d6aefe32 Cr-Commit-Position: refs/heads/master@{#405253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -57 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos_unittest.cc View 7 chunks +44 lines, -3 lines 0 comments Download
D ash/test/virtual_keyboard_test_helper.h View 1 chunk +0 lines, -21 lines 0 comments Download
D ash/test/virtual_keyboard_test_helper.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sadrul
rsadam@ as the test author jamescook@ as the owner.
4 years, 5 months ago (2016-07-13 18:30:49 UTC) #3
rsadam
lgtm
4 years, 5 months ago (2016-07-13 18:33:06 UTC) #5
James Cook
LGTM. Thanks for fixing this! Now my local test runs will go a little faster.
4 years, 5 months ago (2016-07-13 19:16:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151603002/1
4 years, 5 months ago (2016-07-13 19:34:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:07:48 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:08:27 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:10:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f26aa45a91493bb65a452ac671b66ed6d6aefe32
Cr-Commit-Position: refs/heads/master@{#405253}

Powered by Google App Engine
This is Rietveld 408576698