Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/test/data/autofill/heuristics/input/007_i18n_ko.html

Issue 2151593002: Fix regex for last name field in Autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test case for field detection of Korean full names. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/007_i18n_ko.out » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/autofill/heuristics/input/007_i18n_ko.html
diff --git a/chrome/test/data/autofill/heuristics/input/007_i18n_ko.html b/chrome/test/data/autofill/heuristics/input/007_i18n_ko.html
index 15b3a42f08751ad72dac54fa5a803312c165dd77..86f348f8c34fa7bb23d985f83ae2d2385fda3e6f 100644
--- a/chrome/test/data/autofill/heuristics/input/007_i18n_ko.html
+++ b/chrome/test/data/autofill/heuristics/input/007_i18n_ko.html
@@ -24,5 +24,14 @@
<label for="ph">전화 번호:</label> <input type="text" id="ph"><br>
<label for="ph2">휴대폰번호:</label> <input type="text" id="ph2"><br>
</form>
+ <form method="post">
+ <!-- check that "성명" (full name) does not accidentally match "성" (last
sebsg 2016/07/14 15:35:19 Can you put that one in the first form (and thus n
nicolaso 2016/07/14 19:19:44 I improved the test for it to be more significant.
+ name) -->
+ <label for="not_ln2">성명</label> <input type="text" id="not_ln2"><br>
+ <!-- the next fields are just there to fulfill the "minimium 3 fields"
+ requirement for field detection -->
+ <label for="ct3">city</label> <input type="text" id="ct3"><br>
+ <label for="zc3">zip code</label> <input type="text" id="zc3"><br>
+ </form>
</body>
</html>
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/007_i18n_ko.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698