extensions/common/features/manifest_feature.cc - Issue 2151583003: [Extensions] Add extension feature generation code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/manifest_feature.cc

Issue 2151583003: [Extensions] Add extension feature generation code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Include fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/manifest_feature.cc

diff --git a/extensions/common/features/manifest_feature.cc b/extensions/common/features/manifest_feature.cc

index 2245dee24e23490587e1767489b3a70e08f72a0b..313142d6843e106c64fe5c35e4ff53af10b49ecb 100644

--- a/extensions/common/features/manifest_feature.cc

+++ b/extensions/common/features/manifest_feature.cc

@@ -38,13 +38,13 @@ bool ManifestFeature::Validate(std::string* error) {

if (!SimpleFeature::Validate(error))

return false;

- if (extension_types()->empty()) {

+ if (extension_types().empty()) {

*error = name() + ": Manifest features must specify at least one " +

"value for extension_types.";

return false;

}

- if (!contexts()->empty()) {

+ if (!contexts().empty()) {

*error = name() + ": Manifest features do not support contexts.";

return false;

}