chrome/common/extensions/api/common_extension_api_unittest.cc - Issue 2151583003: [Extensions] Add extension feature generation code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 2151583003: [Extensions] Add extension feature generation code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Include fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/common_extension_api_unittest.cc

diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc

index e16ecdf8de638f2e17010178230794498bec875f..c451ea414898e5c766f2fce9873471a7d8d9fe70 100644

--- a/chrome/common/extensions/api/common_extension_api_unittest.cc

+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc

@@ -666,11 +666,11 @@ TEST(ExtensionAPITest, DefaultConfigurationFeatures) {

SimpleFeature* feature = test_data[i].feature;

ASSERT_TRUE(feature) << i;

- EXPECT_TRUE(feature->whitelist()->empty());

- EXPECT_TRUE(feature->extension_types()->empty());

+ EXPECT_TRUE(feature->whitelist().empty());

+ EXPECT_TRUE(feature->extension_types().empty());

EXPECT_EQ(SimpleFeature::UNSPECIFIED_LOCATION, feature->location());

- EXPECT_TRUE(feature->platforms()->empty());

+ EXPECT_TRUE(feature->platforms().empty());

EXPECT_EQ(0, feature->min_manifest_version());

EXPECT_EQ(0, feature->max_manifest_version());

}

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »