[Extensions] Add extension feature generation code

extensions/common/features/base_feature_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/base_feature_provider.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <utility>
 
 #include "base/stl_util.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/features/feature.h"
 #include "extensions/common/features/simple_feature.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace extensions {
 
 // Tests that a real manifest feature is available for the correct types of
 // extensions and apps.
 TEST(BaseFeatureProviderTest, ManifestFeatureTypes) {
   // NOTE: This feature cannot have multiple rules, otherwise it is not a
   // SimpleFeature.
   const SimpleFeature* feature = static_cast<const SimpleFeature*>(
       FeatureProvider::GetManifestFeature("description"));
   ASSERT_TRUE(feature);
-  const std::vector<Manifest::Type>* extension_types =
+  const std::vector<Manifest::Type>& extension_types =
       feature->extension_types();
-  EXPECT_EQ(6u, extension_types->size());
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_EXTENSION));
-  EXPECT_EQ(1,
-            STLCount(*(extension_types), Manifest::TYPE_LEGACY_PACKAGED_APP));
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_PLATFORM_APP));
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_HOSTED_APP));
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_THEME));
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_SHARED_MODULE));
+  EXPECT_EQ(6u, extension_types.size());
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_EXTENSION));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_HOSTED_APP));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_THEME));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_SHARED_MODULE));
 }
 
 // Tests that real manifest features have the correct availability for an
 // extension.
 TEST(BaseFeatureProviderTest, ManifestFeatureAvailability) {
   const FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
 
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
           .SetManifest(DictionaryBuilder()
@@ skipping 28 matching lines @@
 }
 
 // Tests that a real permission feature is available for the correct types of
 // extensions and apps.
 TEST(BaseFeatureProviderTest, PermissionFeatureTypes) {
   // NOTE: This feature cannot have multiple rules, otherwise it is not a
   // SimpleFeature.
   const SimpleFeature* feature = static_cast<const SimpleFeature*>(
       BaseFeatureProvider::GetPermissionFeature("power"));
   ASSERT_TRUE(feature);
-  const std::vector<Manifest::Type>* extension_types =
+  const std::vector<Manifest::Type>& extension_types =
       feature->extension_types();
-  EXPECT_EQ(3u, extension_types->size());
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_EXTENSION));
-  EXPECT_EQ(1,
-            STLCount(*(extension_types), Manifest::TYPE_LEGACY_PACKAGED_APP));
-  EXPECT_EQ(1, STLCount(*(extension_types), Manifest::TYPE_PLATFORM_APP));
+  EXPECT_EQ(3u, extension_types.size());
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_EXTENSION));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
+  EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
 }
 
 // Tests that real permission features have the correct availability for an app.
 TEST(BaseFeatureProviderTest, PermissionFeatureAvailability) {
   const FeatureProvider* provider =
       BaseFeatureProvider::GetByName("permission");
 
   scoped_refptr<const Extension> app =
       ExtensionBuilder()
           .SetManifest(
@@ skipping 34 matching lines @@
   // A permission that isn't part of the manifest returns NOT_PRESENT.
   feature = provider->GetFeature("serial");
   ASSERT_TRUE(feature);
   EXPECT_EQ(
       Feature::NOT_PRESENT,
       feature->IsAvailableToContext(
                    app.get(), Feature::UNSPECIFIED_CONTEXT, GURL()).result());
 }
 
 }  // namespace extensions