Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: extensions/common/features/manifest_feature.cc

Issue 2151583003: [Extensions] Add extension feature generation code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GYP support Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/features/manifest_feature.h" 5 #include "extensions/common/features/manifest_feature.h"
6 6
7 #include "extensions/common/manifest.h" 7 #include "extensions/common/manifest.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 10
(...skipping 21 matching lines...) Expand all
32 return CreateAvailability(NOT_PRESENT, extension->GetType()); 32 return CreateAvailability(NOT_PRESENT, extension->GetType());
33 33
34 return CreateAvailability(IS_AVAILABLE); 34 return CreateAvailability(IS_AVAILABLE);
35 } 35 }
36 36
37 std::string ManifestFeature::Parse(const base::DictionaryValue* value) { 37 std::string ManifestFeature::Parse(const base::DictionaryValue* value) {
38 std::string error = SimpleFeature::Parse(value); 38 std::string error = SimpleFeature::Parse(value);
39 if (!error.empty()) 39 if (!error.empty())
40 return error; 40 return error;
41 41
42 if (extension_types()->empty()) { 42 if (extension_types().empty()) {
43 return name() + ": Manifest features must specify at least one " + 43 return name() + ": Manifest features must specify at least one " +
44 "value for extension_types."; 44 "value for extension_types.";
45 } 45 }
46 46
47 if (value->HasKey("contexts")) 47 if (value->HasKey("contexts"))
48 return name() + ": Manifest features do not support contexts."; 48 return name() + ": Manifest features do not support contexts.";
49 49
50 return std::string(); 50 return std::string();
51 } 51 }
52 52
53 } // namespace extensions 53 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698