[DevTools] Fix window object init on chrome://* pages

[DevTools] Fix window object init on chrome://* pages

BUG=627407
R=dgozman@chromium.org

Committed: https://crrev.com/3ac9439a02b4185916378572f343f1870f71fc4b
Cr-Commit-Position: refs/heads/master@{#405358}

[kozy, 2016-07-13 17:47:21]

Dmitry, please take a look!

[kozy, 2016-07-13 17:52:27]

@tsepez, please take a look at StaticURLDataSource in
chrome/browser/devtools/devtools_sanity_browsertest.cc.

https://codereview.chromium.org/2151573002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_sanity_browsertest.cc (right):

https://codereview.chromium.org/2151573002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_sanity_browsertest.cc:1378: bool
ShouldAddContentSecurityPolicy() const override { return false; }
@tsepez, could I bypass CSP in test? There is "Do not disable CSP on your page
without first contacting the chrome security team." comment in [1].

[1]
https://cs.chromium.org/chromium/src/content/public/browser/url_data_source.h...

[kozy, 2016-07-13 17:53:02]

kozyatinskiy@chromium.org changed reviewers:
+ tsepez@chromium.org

[kozy, 2016-07-13 17:53:02]

@tsepez, please take a look at StaticURLDataSource in
chrome/browser/devtools/devtools_sanity_browsertest.cc.

[Tom Sepez, 2016-07-13 18:04:08]

https://codereview.chromium.org/2151573002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_sanity_browsertest.cc (right):

https://codereview.chromium.org/2151573002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_sanity_browsertest.cc:1378: bool
ShouldAddContentSecurityPolicy() const override { return false; }
On 2016/07/13 17:52:27, kozyatinskiy wrote:
> @tsepez, could I bypass CSP in test? There is "Do not disable CSP on your page
> without first contacting the chrome security team." comment in [1].
> 
> [1]
>
https://cs.chromium.org/chromium/src/content/public/browser/url_data_source.h...

This should be fine for test code.  Thanks.

[dgozman, 2016-07-13 18:40:59]

inspector lgtm

+haraken for ScriptController.cpp. I think this is even better that previous
solution - we do not force contexts in ScriptController anymore. WDYT?

https://codereview.chromium.org/2151573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2151573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1547: if
(forceMainWorldInitialization)
Please inline it:

if (settings && settings->forceMainWorldInitialization())

[kozy, 2016-07-13 18:57:26]

kozyatinskiy@chromium.org changed reviewers:
+ haraken@chromium.org

[kozy, 2016-07-13 18:57:27]

All done.

@haraken, please take a look at ScriptController.

https://codereview.chromium.org/2151573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2151573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1547: if
(forceMainWorldInitialization)
On 2016/07/13 18:40:59, dgozman wrote:
> Please inline it:
> 
> if (settings && settings->forceMainWorldInitialization())

Done.

[kozy, 2016-07-13 19:09:25]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:36:55]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-07-13 23:54:29]

bindings/ LGTM

[kozy, 2016-07-13 23:57:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-13 23:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2151573002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-07-13 23:59:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:08:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 00:13:38]

Description was changed from

==========
[DevTools] Fix window object init on chrome://* pages

BUG=627407
R=dgozman@chromium.org
==========

to

==========
[DevTools] Fix window object init on chrome://* pages

BUG=627407
R=dgozman@chromium.org

Committed: https://crrev.com/3ac9439a02b4185916378572f343f1870f71fc4b
Cr-Commit-Position: refs/heads/master@{#405358}
==========

[commit-bot: I haz the power, 2016-07-14 00:13:40]

Patchset 3 (id:??) landed as
https://crrev.com/3ac9439a02b4185916378572f343f1870f71fc4b
Cr-Commit-Position: refs/heads/master@{#405358}