Add the fields bits-per-pixel and bits-per-component to Display.

Add the fields bits-per-pixel and bits-per-component to Display.

On Android we currently use an object called DeviceDisplayInfo to hold
information about a display. To replace this object with
ui::display::Display we need to add some fields, that are specific to
Android, to Display.

BUG=625089
Committed: https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909
Cr-Commit-Position: refs/heads/master@{#407821}

[gsennton, 2016-07-13 17:42:58]

gsennton@chromium.org changed reviewers:
+ oshima@chromium.org

[gsennton, 2016-07-13 17:42:59]

Hi oshima@, could you look at ui/display/ changes pls? :)

[oshima, 2016-07-14 14:09:37]

https://codereview.chromium.org/2151563002/diff/1/ui/display/display.h
File ui/display/display.h (right):

https://codereview.chromium.org/2151563002/diff/1/ui/display/display.h#newcod...
ui/display/display.h:176: int bits_per_component_;
In WebScreenInfo, they're

depth
depthPerComponent

how about color_depth, depth_per_Component ?

[gsennton, 2016-07-14 14:34:07]

https://codereview.chromium.org/2151563002/diff/1/ui/display/display.h
File ui/display/display.h (right):

https://codereview.chromium.org/2151563002/diff/1/ui/display/display.h#newcod...
ui/display/display.h:176: int bits_per_component_;
On 2016/07/14 14:09:37, oshima wrote:
> In WebScreenInfo, they're
> 
> depth
> depthPerComponent
> 
> how about color_depth, depth_per_Component ?

I don't have a strong opinion about the naming here :)
Will fix and re-upload.

[gsennton, 2016-07-14 14:53:26]

Adding sievers@ for render_widget_host_view_android

[gsennton, 2016-07-14 14:53:48]

gsennton@chromium.org changed reviewers:
+ sievers@chromium.org

[oshima, 2016-07-14 15:30:54]

ui/display lgtm

[gsennton, 2016-07-20 09:35:51]

ping for sievers@ :)

[no sievers, 2016-07-20 21:09:39]

lgtm

[gsennton, 2016-07-26 13:49:57]

The CQ bit was checked by gsennton@chromium.org

[commit-bot: I haz the power, 2016-07-26 13:50:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 13:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 13:51:34]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[gsennton, 2016-07-26 15:02:25]

The CQ bit was checked by gsennton@chromium.org

[gsennton, 2016-07-26 15:02:25]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2151563002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-26 15:02:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:07:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-26 16:08:31]

Description was changed from

==========
Add the fields bits-per-pixel and bits-per-component to Display.

On Android we currently use an object called DeviceDisplayInfo to hold
information about a display. To replace this object with
ui::display::Display we need to add some fields, that are specific to
Android, to Display.

BUG=625089
==========

to

==========
Add the fields bits-per-pixel and bits-per-component to Display.

On Android we currently use an object called DeviceDisplayInfo to hold
information about a display. To replace this object with
ui::display::Display we need to add some fields, that are specific to
Android, to Display.

BUG=625089

Committed: https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909
Cr-Commit-Position: refs/heads/master@{#407821}
==========

[commit-bot: I haz the power, 2016-07-26 16:08:32]

Patchset 3 (id:??) landed as
https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909
Cr-Commit-Position: refs/heads/master@{#407821}