Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2151553002: Remove Enable Exits On Suspend flags on iOS (Closed)

Created:
4 years, 5 months ago by gambard
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Enable Exits On Suspend flags on iOS This CL removes the Enable Exits On Suspend flag on iOS. BUG=627859 Committed: https://crrev.com/c8ae1453cbc9ee793144a6da2c3a41e5db2aeae2 Cr-Commit-Position: refs/heads/master@{#406234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -144 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/app/UIApplication+ExitsOnSuspend.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ios/chrome/app/UIApplication+ExitsOnSuspend.mm View 1 chunk +0 lines, -110 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
gambard
PTAL.
4 years, 5 months ago (2016-07-13 16:01:38 UTC) #2
rohitrao (ping after 24h)
LGTM Please do not land until the downstream uses have been removed.
4 years, 5 months ago (2016-07-13 16:10:44 UTC) #3
lpromero
lgtm
4 years, 5 months ago (2016-07-13 22:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151553002/1
4 years, 5 months ago (2016-07-19 07:50:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 09:40:30 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 09:40:34 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8ae1453cbc9ee793144a6da2c3a41e5db2aeae2 Cr-Commit-Position: refs/heads/master@{#406234}
4 years, 5 months ago (2016-07-19 09:44:00 UTC) #10
sdefresne
4 years, 5 months ago (2016-07-19 12:51:07 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2162893002/ by sdefresne@chromium.org.

The reason for reverting is: Broke downstream tree as -[UIApplication
cr_interpose_beginBackgroundTaskWithExpirationHandler:] is used..

Powered by Google App Engine
This is Rietveld 408576698