For determining OWNERS, drop reviewers specified via '-r' that aren't in email address format.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 834 matching lines @@
 
 
 def _GetRietveldIssueProps(input_api, messages):
   """Gets the issue properties from rietveld."""
   issue = input_api.change.issue
   if issue and input_api.rietveld:
     return input_api.rietveld.get_issue_properties(
         issue=int(issue), messages=messages)
 
 
+def _EnsureEmailFormat(reviewer):
+  """Converts |reviewer| into an email address if it is not one already."""
+  if '@' in reviewer:
+    return reviewer
+  return reviewer + '@chromium.org'
+
+
 def _ReviewersFromChange(change):
   """Return the reviewers specified in the |change|, if any."""
   reviewers = set()
   if change.R:
     reviewers.update(set([r.strip() for r in change.R.split(',')]))
   if change.TBR:
     reviewers.update(set([r.strip() for r in change.TBR.split(',')]))
-  return reviewers
+  return set([_EnsureEmailFormat(reviewer) for reviewer in reviewers])

[M-A Ruel, 2014/03/28 00:19:35]

FTR;
return set(_EnsureEmailFormat(reviewer) for reviewer in reviewers)

[Ilya Sherman, 2014/04/09 01:34:59]

Done.

 
 
 def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
   """Return the owner and reviewers of a change, if any.
 
   If approval_needed is True, only reviewers who have approved the change
   will be returned.
   """
   issue_props = _GetRietveldIssueProps(input_api, True)
   if not issue_props:
@@ skipping 186 matching lines @@
 def CheckPatchFormatted(input_api, output_api):
   import git_cl
   cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]
   code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
   if code == 2:
     return [output_api.PresubmitPromptWarning(
       'Your patch is not formatted, please run git cl format.')]
   # As this is just a warning, ignore all other errors if the user
   # happens to have a broken clang-format, doesn't use git, etc etc.
   return []