gcapi_mac: Fix GoogleChromeCompatibilityCheck() return value

gcapi_mac: Fix GoogleChromeCompatibilityCheck() return value

GCCC_ERROR_ACCESSDENIED is a reason value, not a return value.

GetRealUserId() doesn't need to be called until it's needed, and if it
fails, only FindChromeTicket(kUserTicket) needs to be skipped, not the
whole rest of the function.

Committed: https://crrev.com/e622fe0e6737ccfd74bd98205a5a9d79d3852719
Cr-Commit-Position: refs/heads/master@{#405158}

[Mark Mentovai, 2016-07-13 14:50:22]

mark@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-07-13 14:52:31]

lgtm

Out of interest, is this just a general cleanup or is this motivated by testing?

In any case, thanks for the patch!

[Mark Mentovai, 2016-07-13 14:54:28]

A little of each.

Someone else was testing this code and asked me for advice yesterday. In the
process, I accidentally read through a little bit of the code and spotted an
opportunity for general cleanup.

[Mark Mentovai, 2016-07-13 14:54:38]

The CQ bit was checked by mark@chromium.org

[commit-bot: I haz the power, 2016-07-13 14:55:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:30:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 15:33:27]

Description was changed from

==========
gcapi_mac: Fix GoogleChromeCompatibilityCheck() return value

GCCC_ERROR_ACCESSDENIED is a reason value, not a return value.

GetRealUserId() doesn't need to be called until it's needed, and if it
fails, only FindChromeTicket(kUserTicket) needs to be skipped, not the
whole rest of the function.
==========

to

==========
gcapi_mac: Fix GoogleChromeCompatibilityCheck() return value

GCCC_ERROR_ACCESSDENIED is a reason value, not a return value.

GetRealUserId() doesn't need to be called until it's needed, and if it
fails, only FindChromeTicket(kUserTicket) needs to be skipped, not the
whole rest of the function.

Committed: https://crrev.com/e622fe0e6737ccfd74bd98205a5a9d79d3852719
Cr-Commit-Position: refs/heads/master@{#405158}
==========

[commit-bot: I haz the power, 2016-07-13 15:33:28]

Patchset 1 (id:??) landed as
https://crrev.com/e622fe0e6737ccfd74bd98205a5a9d79d3852719
Cr-Commit-Position: refs/heads/master@{#405158}