Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2151483007: Plugin Power Saver: Fix a dangling WebViewPlugin. (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Fix a dangling WebViewPlugin. Currently, there can be a situation where if the plugin removes itself during initialization, the container is destroyed but the placeholder plugin is not. This patch fixes this issue. BUG=620515 Committed: https://crrev.com/c37f6c9c5535c9c5e4aaba9d61a93673561ce344 Cr-Commit-Position: refs/heads/master@{#406018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M components/plugins/renderer/loadable_plugin_placeholder.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tommycli
bauerb: PTAL, I think this closes a hole in the logic for placeholder plugin destruction ...
4 years, 5 months ago (2016-07-15 22:02:51 UTC) #2
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-18 11:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151483007/1
4 years, 5 months ago (2016-07-18 16:13:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 16:58:41 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 16:58:48 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:01:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c37f6c9c5535c9c5e4aaba9d61a93673561ce344
Cr-Commit-Position: refs/heads/master@{#406018}

Powered by Google App Engine
This is Rietveld 408576698