Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2151483006: Remove unnecessary std::move() from a //media/gpu file. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary std::move() from a //media/gpu file. Compiling w/ clang on CrOS, the compiler caught an unnecessary std::move() in a CrOS-only file with the -Wpessimizing-move warning. R=posciak@chromium.org, llozano@chromium.org BUG=626241 Committed: https://crrev.com/f3b2adee05ddfc032bf0000fdcbdc3cf17b8b965 Cr-Commit-Position: refs/heads/master@{#406128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Dirk Pranke
I have no idea if this is correct or not, or if it makes the ...
4 years, 5 months ago (2016-07-15 02:09:53 UTC) #4
Dirk Pranke
ping?
4 years, 5 months ago (2016-07-18 21:31:45 UTC) #5
DaleCurtis
Doesn't change anything it's a vector <-> vector stack allocation which should already have move ...
4 years, 5 months ago (2016-07-18 21:33:43 UTC) #7
Dirk Pranke
Thanks!
4 years, 5 months ago (2016-07-18 21:35:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151483006/1
4 years, 5 months ago (2016-07-18 21:37:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:26:59 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:27:15 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:28:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3b2adee05ddfc032bf0000fdcbdc3cf17b8b965
Cr-Commit-Position: refs/heads/master@{#406128}

Powered by Google App Engine
This is Rietveld 408576698