Remove embeddedSearch.newTabPage.GetAppLauncherEnabled

Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207
Committed: https://crrev.com/9f7f6f163a4f1660ea8b078e76dd2261eaee224c
Cr-Commit-Position: refs/heads/master@{#407499}

[Marc Treib, 2016-07-14 09:58:39]

Description was changed from

==========
Remove searchBox.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedId

BUG=627747
==========

to

==========
Remove searchBox.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=627747
==========

[Marc Treib, 2016-07-14 09:59:34]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:59:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-07-14 10:00:02]

treib@chromium.org changed reviewers:
+ jered@chromium.org

[Marc Treib, 2016-07-14 10:00:02]

PTAL!

[commit-bot: I haz the power, 2016-07-14 11:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:09:57]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-07-14 16:20:09]

Description was changed from

==========
Remove searchBox.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=627747
==========

to

==========
Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207
==========

[Marc Treib, 2016-07-19 09:43:54]

Ping!

[Marc Treib, 2016-07-25 09:17:19]

On 2016/07/19 09:43:54, Marc Treib wrote:
> Ping!

Re-ping! Jered, could you take a look? Or if you're not the right reviewer for
this, could you recommend someone else? Thanks!

[Jered, 2016-07-25 14:46:08]

lgtm

https://codereview.chromium.org/2151483004/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/search_tab_helper.cc (right):

https://codereview.chromium.org/2151483004/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/search_tab_helper.cc:23: #include
"chrome/browser/ui/app_list/app_list_util.h"
You can remove this now.

[Marc Treib, 2016-07-25 15:00:48]

https://codereview.chromium.org/2151483004/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/search_tab_helper.cc (right):

https://codereview.chromium.org/2151483004/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/search_tab_helper.cc:23: #include
"chrome/browser/ui/app_list/app_list_util.h"
On 2016/07/25 14:46:08, Jered wrote:
> You can remove this now.

Done.

[Marc Treib, 2016-07-25 15:05:27]

treib@chromium.org changed reviewers:
+ nasko@chromium.org

[Marc Treib, 2016-07-25 15:05:28]

+nasko for render_messages.h. PTAL!

For future reference: Is it acceptable/preferred to TBR a change that only
removes a render message?
Thanks!

[Jered, 2016-07-25 15:08:56]

On 2016/07/25 15:05:28, Marc Treib wrote:
> +nasko for render_messages.h. PTAL!
> 
> For future reference: Is it acceptable/preferred to TBR a change that only
> removes a render message?
> Thanks!

lgtm

Sure, though in this case we did change a public API so it seems wise to get
another look. (I poked around and verified that nobody is using this.)

[nasko, 2016-07-25 15:56:41]

> For future reference: Is it acceptable/preferred to TBR a change that only
> removes a render message?

Not acceptable to TBR. All IPC changes must be reviewed. If you are hitting slow
reviews, there are multiple owners you can ping.

That said, IPC LGTM :).

https://codereview.chromium.org/2151483004/diff/40001/chrome/browser/ui/searc...
File chrome/browser/ui/search/search_tab_helper.cc (left):

https://codereview.chromium.org/2151483004/diff/40001/chrome/browser/ui/searc...
chrome/browser/ui/search/search_tab_helper.cc:267: void
SearchTabHelper::RenderViewCreated(
Super happy to see this go! Thanks!

[Marc Treib, 2016-07-25 16:19:16]

On 2016/07/25 15:56:41, nasko wrote:
> > For future reference: Is it acceptable/preferred to TBR a change that only
> > removes a render message?
> 
> Not acceptable to TBR. All IPC changes must be reviewed. If you are hitting
slow
> reviews, there are multiple owners you can ping.

No problem with reviews, I was just wondering if this was a "don't even bug me
with this trivial stuff" situation :)
Thanks!

> That said, IPC LGTM :).

[Marc Treib, 2016-07-25 16:19:29]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:13:59]

Description was changed from

==========
Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207
==========

to

==========
Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207
==========

[commit-bot: I haz the power, 2016-07-25 17:14:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 17:16:26]

Description was changed from

==========
Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207
==========

to

==========
Remove embeddedSearch.newTabPage.GetAppLauncherEnabled
and all the related IPC code

It's not used anywhere, and it's not documented at
http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207

Committed: https://crrev.com/9f7f6f163a4f1660ea8b078e76dd2261eaee224c
Cr-Commit-Position: refs/heads/master@{#407499}
==========

[commit-bot: I haz the power, 2016-07-25 17:16:28]

Patchset 3 (id:??) landed as
https://crrev.com/9f7f6f163a4f1660ea8b078e76dd2261eaee224c
Cr-Commit-Position: refs/heads/master@{#407499}