DescriptionRevert of RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation (patchset #2 id:20001 of https://codereview.chromium.org/2146973002/ )
Reason for revert:
It caused timeout in
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
see
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/56929
Original issue's description:
> RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation
>
> Got reverted due to breaking
> WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
> in some WebRtc Mac bot, possibly because it has no real WebCam
> or it has one without AVCaptureStillImageOutputClass support.
>
> This CL adds a guard [captureSession_ canAddOutput:...]
> before [captureSession_ addOutput:...]
>
> Original description ----------------------------------------------
> ImageCapture: Implement takePhoto() for Mac AVFoundation
>
> By pulling the necessary symbols out of AVFoundation
> and using them; most notably (Cr)AVCaptureStillImageOutput.
>
> TakePhoto is already implemented for Android (both APIs).
>
> Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
> test case, enabled only for Mac.
>
> BUG=518807
> TEST=Run build with flag --enable-blink-features=ImageCapture,
> navigate to [1] and push buttons
> - Open Camera ...
> - Create ImageCapturer
> - takePhoto() (N times!) --> profit
>
> [1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
>
> TBR=rsesek@chromium.org since the change is trivial.
>
> Committed: https://crrev.com/d4179235b928634aeadb0c3379d385caf0ad3a07
> Cr-Commit-Position: refs/heads/master@{#405243}
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Committed: https://crrev.com/547610b292537c8aef1744ea65791e566bc9ae7b
Cr-Commit-Position: refs/heads/master@{#405294}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|