Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2151443003: Revert of RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation (patchset #2 id:20001 of https://codereview.chromium.org/2146973002/ ) Reason for revert: It caused timeout in WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0 see https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/56929 Original issue's description: > RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation > > Got reverted due to breaking > WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0 > in some WebRtc Mac bot, possibly because it has no real WebCam > or it has one without AVCaptureStillImageOutputClass support. > > This CL adds a guard [captureSession_ canAddOutput:...] > before [captureSession_ addOutput:...] > > Original description ---------------------------------------------- > ImageCapture: Implement takePhoto() for Mac AVFoundation > > By pulling the necessary symbols out of AVFoundation > and using them; most notably (Cr)AVCaptureStillImageOutput. > > TakePhoto is already implemented for Android (both APIs). > > Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto > test case, enabled only for Mac. > > BUG=518807 > TEST=Run build with flag --enable-blink-features=ImageCapture, > navigate to [1] and push buttons > - Open Camera ... > - Create ImageCapturer > - takePhoto() (N times!) --> profit > > [1] https://rawgit.com/Miguelao/demos/master/imagecapture.html > > TBR=rsesek@chromium.org since the change is trivial. > > Committed: https://crrev.com/d4179235b928634aeadb0c3379d385caf0ad3a07 > Cr-Commit-Position: refs/heads/master@{#405243} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807 Committed: https://crrev.com/547610b292537c8aef1744ea65791e566bc9ae7b Cr-Commit-Position: refs/heads/master@{#405294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -226 lines) Patch
M media/base/mac/avfoundation_glue.h View 5 chunks +6 lines, -20 lines 0 comments Download
M media/base/mac/avfoundation_glue.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/mac/coremedia_glue.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.h View 4 chunks +2 lines, -10 lines 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.mm View 6 chunks +13 lines, -73 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.h View 2 chunks +1 line, -13 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 3 chunks +2 lines, -31 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 10 chunks +12 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mcasas
Created Revert of RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation
4 years, 5 months ago (2016-07-13 21:26:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151443003/1
4 years, 5 months ago (2016-07-13 21:27:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 21:34:39 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 21:35:26 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:36:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/547610b292537c8aef1744ea65791e566bc9ae7b
Cr-Commit-Position: refs/heads/master@{#405294}

Powered by Google App Engine
This is Rietveld 408576698