Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2151433005: Slight cleanup of TryCatch parsing/variable declaration (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Slight cleanup of TryCatch parsing/variable declaration Instead of unconditionally parsing the catch parameter as an expression and then recovering if it turns out to be a simple variable proxy (the overwhelmingly common case), this patch peeks one token ahead before attempting to parse. This avoids doing the usual RemoveUnresolved gymnastics in ParseTryStatement, and as a side-effect slightly improves function name inference for an async arrow function test case. Committed: https://crrev.com/458bd3b9a3ee150a19d729a6970065b5ec0a0e17 Cr-Commit-Position: refs/heads/master@{#37780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/parsing/parser.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/async-function-stacktrace.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
adamk
4 years, 5 months ago (2016-07-13 21:37:21 UTC) #4
neis
Nice! lgtm
4 years, 5 months ago (2016-07-14 08:14:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151433005/1
4 years, 5 months ago (2016-07-14 17:19:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 17:52:39 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 17:52:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:55:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/458bd3b9a3ee150a19d729a6970065b5ec0a0e17
Cr-Commit-Position: refs/heads/master@{#37780}

Powered by Google App Engine
This is Rietveld 408576698