cc/layers/surface_layer_unittest.cc - Issue 2151433004: cc: Make LayerTreeHostImpl::SwapBuffers not virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/surface_layer_unittest.cc

Issue 2151433004: cc: Make LayerTreeHostImpl::SwapBuffers not virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removedidswap

Patch Set: novirtualswapbuffers: self-nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/surface_layer_unittest.cc

diff --git a/cc/layers/surface_layer_unittest.cc b/cc/layers/surface_layer_unittest.cc

index 8ff9ad970c5f0e0d8b2e7fffe77a3a9a69206a51..b806833f6c3f87fe88b8054b7056367cf78a934c 100644

--- a/cc/layers/surface_layer_unittest.cc

+++ b/cc/layers/surface_layer_unittest.cc

@@ -191,8 +191,7 @@ class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {

}

- void SwapBuffersOnThread(LayerTreeHostImpl* host_impl, bool result) override {

- EXPECT_TRUE(result);

+ void SwapBuffersCompleteOnThread() override {

std::vector<uint32_t>& satisfied =

output_surface()->last_sent_frame()->metadata.satisfies_sequences;

EXPECT_LE(satisfied.size(), 1u);

« no previous file with comments | « no previous file | cc/layers/texture_layer_unittest.cc » ('j') | cc/trees/layer_tree_host_unittest_damage.cc » ('J')