Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3933)

Unified Diff: cc/test/test_hooks.h

Issue 2151433004: cc: Make LayerTreeHostImpl::SwapBuffers not virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removedidswap
Patch Set: novirtualswapbuffers: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/test_hooks.h
diff --git a/cc/test/test_hooks.h b/cc/test/test_hooks.h
index 299729ae7bef373ac0e14eb7be017c6094ef75a7..89807e46ca72929f7b5fbeb5b898eae12c1b7a32 100644
--- a/cc/test/test_hooks.h
+++ b/cc/test/test_hooks.h
@@ -46,8 +46,11 @@ class TestHooks : public AnimationDelegate {
LayerTreeHostImpl::FrameData* frame_data,
DrawResult draw_result);
virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) {}
- virtual void SwapBuffersOnThread(LayerTreeHostImpl* host_impl, bool result) {}
- virtual void SwapBuffersCompleteOnThread(LayerTreeHostImpl* host_impl) {}
+ // Note that this is called asynchronously from the LayerTreeHostImpl
+ // performing its draw, so you should record state you want to use here
+ // in DrawLayersOnThread() instead. For that reason this method does not
+ // receive a LayerTreeHostImpl pointer.
+ virtual void SwapBuffersCompleteOnThread() {}
virtual void NotifyReadyToActivateOnThread(LayerTreeHostImpl* host_impl) {}
virtual void NotifyReadyToDrawOnThread(LayerTreeHostImpl* host_impl) {}
virtual void NotifyAllTileTasksCompleted(LayerTreeHostImpl* host_impl) {}

Powered by Google App Engine
This is Rietveld 408576698