Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: third_party/WebKit/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp

Issue 21514: A review before upstreaming a patch to WebCore. Linux events need disambiguat... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp
===================================================================
--- third_party/WebKit/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp (revision 9965)
+++ third_party/WebKit/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp (working copy)
@@ -42,7 +42,7 @@
#if PLATFORM(WIN_OS)
// No KeyDown events on Windows to disambiguate.
ASSERT_NOT_REACHED();
-#elif PLATFORM(DARWIN)
+#else
// Can only change type from KeyDown to RawKeyDown or Char, as we lack information for other conversions.
ASSERT(m_type == KeyDown);
ASSERT(type == RawKeyDown || type == Char);
@@ -56,6 +56,7 @@
} else {
m_keyIdentifier = String();
m_windowsVirtualKeyCode = 0;
+#if PLATFORM(DARWIN)
if (m_text.length() == 1 && (m_text[0U] >= 0xF700 && m_text[0U] <= 0xF7FF)) {
// According to NSEvents.h, OpenStep reserves the range 0xF700-0xF8FF for function keys. However, some actual private use characters
// happen to be in this range, e.g. the Apple logo (Option+Shift+K).
@@ -63,6 +64,7 @@
m_text = String();
m_unmodifiedText = String();
}
+#endif
}
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698