Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2151393002:
Disable GPU raster for OSX 10.9 (Closed)
|
Created:
4 years, 5 months ago by ericrk Modified:
4 years, 5 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable GPU raster for OSX 10.9
crbug.com/611310 contains a report of a rendering issue on 10.9. As I
haven't been able to repro locally, I was hoping to get more data on
this issue during beta/canary, but no additional reports have come in.
In order to allow us to launch to stable with lower risk, this CL
disables GPU raster on 10.9, which only accounts for ~7% of mac users.
We may re-enable this for M53 Beta M54 Canary in order to track down the
issue in question, and hopefully launch to 10.9 in M53.
BUG=611310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/51630e3efbcde407cdc7c4e0f35cba88a2090601
Cr-Commit-Position: refs/heads/master@{#405902}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M43 Beta M44 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M43. BUG=611310 ========== to ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M43 Beta M44 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M43. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + kbr@chromium.org
Not sure if this is a bit too conservative, but I'd rather head off these issues now and try to launch to 10.9 in M53, rather than potentially ending up unable to launch everywhere else in M52 due to this bug.
Description was changed from ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M43 Beta M44 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M43. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M53 Beta M54 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M53. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M53 Beta M54 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M53. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M53 Beta M54 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M53. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M53 Beta M54 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M53. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable GPU raster for OSX 10.9 crbug.com/611310 contains a report of a rendering issue on 10.9. As I haven't been able to repro locally, I was hoping to get more data on this issue during beta/canary, but no additional reports have come in. In order to allow us to launch to stable with lower risk, this CL disables GPU raster on 10.9, which only accounts for ~7% of mac users. We may re-enable this for M53 Beta M54 Canary in order to track down the issue in question, and hopefully launch to 10.9 in M53. BUG=611310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/51630e3efbcde407cdc7c4e0f35cba88a2090601 Cr-Commit-Position: refs/heads/master@{#405902} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/51630e3efbcde407cdc7c4e0f35cba88a2090601 Cr-Commit-Position: refs/heads/master@{#405902} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
