Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 2151373002: Share LibrarySpecificUnits when possible (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Clean-up Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/cache.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 858fd0636a60235d799a0f331834c973c7a6e256..c7488b2b615c3db10d8241c9f38810a39c83fd2d 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -644,6 +644,14 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
@override
+ AnalysisTarget canonicalizeTarget(AnalysisTarget target) {
+ if (target is LibrarySpecificUnit) {
+ return getLibrarySpecificUnit(target.library, target.unit);
+ }
+ return target;
+ }
+
+ @override
String computeDocumentationComment(Element element) =>
element?.documentationComment;
@@ -856,6 +864,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
CacheEntry getCacheEntry(AnalysisTarget target) {
CacheEntry entry = _cache.get(target);
if (entry == null) {
+ target = canonicalizeTarget(target);
entry = new CacheEntry(target);
ImplicitAnalysisEvent event = null;
if (target is Source) {
@@ -1007,6 +1016,22 @@ class AnalysisContextImpl implements InternalAnalysisContext {
getResult(source, LIBRARY_ELEMENT);
@override
+ LibrarySpecificUnit getLibrarySpecificUnit(Source library, Source unit) {
+ CacheEntry entry = analysisCache.get(unit);
+ if (entry != null) {
+ LibrarySpecificUnit lsu = entry.librarySpecificUnit;
+ if (lsu == null) {
+ lsu = new LibrarySpecificUnit(library, unit);
+ entry.librarySpecificUnit = lsu;
+ return lsu;
+ } else if (lsu.library == library && lsu.unit == unit) {
+ return lsu;
+ }
+ }
+ return new LibrarySpecificUnit(library, unit);
+ }
+
+ @override
LineInfo getLineInfo(Source source) => getResult(source, LINE_INFO);
@override
« no previous file with comments | « pkg/analyzer/lib/src/context/cache.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698