tools/metrics/histograms/histograms.xml - Issue 2151363003: Split redirect delay metrics into separate histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2151363003: Split redirect delay metrics into separate histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 70a05c4ce59c1ca483dcbeabccef53e86213dff7..3332d96b048a7dafdb538034f067391744d12a65 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -37518,14 +37518,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="PageLoad.Internal.ClientRedirectDelayAfterPaint" units="ms">

Ilya Sherman 2016/07/15 23:05:38 Please mark this histogram as obsolete.

Bryan McQuade 2016/07/17 13:18:06 Done.

+<histogram name="PageLoad.Internal.ClientRedirect.FirstPaintToNavigation"

+ units="ms">

<owner>bmcquade@chromium.org</owner>

- The delay between first paint and a client-side redirection. This metric is

- only intended to help in choosing a heuristic delay to distinguish between

- client-side redirects and other client initiated navigations, and will be

- deprecated in M54. Please contact bmcquade@chromium.org before using this

- metric.

+ The delay between first paint and a client-side redirect navigation, for

+ pages that reported a first paint. This metric is only intended to help in

+ choosing a heuristic delay to distinguish between client-side redirects and

+ other client initiated navigations, and will be deprecated in M54. Please

+ contact bmcquade@chromium.org before using this metric.

+ </summary>

+</histogram>

+<histogram name="PageLoad.Internal.ClientRedirect.NavigationWithoutPaint">

+ <owner>bmcquade@chromium.org</owner>

+ <summary>

+ Counts how often a client-side redirect was initiated from a page that did

+ not report a first paint. This metric is only intended to help in choosing a

+ heuristic delay to distinguish between client-side redirects and other

+ client initiated navigations, and will be deprecated in M54. Please contact

+ bmcquade@chromium.org before using this metric.

</summary>

</histogram>