Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Issue 2151363002: Fixing a cursor position initialization problem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java b/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
index 9d2c596f0c612edf7d1e9203cd97d6d1e22a8fc9..4d2b04fd3e206a9f54d74ee9836045739bef166d 100644
--- a/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
+++ b/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
@@ -21,6 +21,7 @@ import android.view.ViewConfiguration;
*/
public class TouchInputHandler {
private final DesktopViewInterface mViewer;
+
private final Context mContext;
private final RenderData mRenderData;
private final DesktopCanvas mDesktopCanvas;
@@ -361,8 +362,12 @@ public class TouchInputHandler {
synchronized (mRenderData) {
screenCenterX = (float) mRenderData.screenWidth / 2;
screenCenterY = (float) mRenderData.screenHeight / 2;
+
+ float[] imagePoint = mapScreenPointToImagePoint(screenCenterX, screenCenterY);
+ mDesktopCanvas.setViewportPosition(imagePoint[0], imagePoint[1]);
}
moveCursorToScreenPoint(screenCenterX, screenCenterY);
+ mDesktopCanvas.repositionImage(true);
}
private void setInputStrategy(InputStrategyInterface inputStrategy) {
@@ -399,13 +404,8 @@ public class TouchInputHandler {
/** Moves the cursor to the specified position on the screen. */
private void moveCursorToScreenPoint(float screenX, float screenY) {
- float[] mappedValues = {screenX, screenY};
- synchronized (mRenderData) {
- Matrix canvasToImage = new Matrix();
- mRenderData.transform.invert(canvasToImage);
- canvasToImage.mapPoints(mappedValues);
- }
- moveCursor((int) mappedValues[0], (int) mappedValues[1]);
+ float[] imagePoint = mapScreenPointToImagePoint(screenX, screenY);
+ moveCursor((int) imagePoint[0], (int) imagePoint[1]);
}
/** Moves the cursor to the specified position on the remote host. */
@@ -437,6 +437,18 @@ public class TouchInputHandler {
return true;
}
+ /** Translates a point in screen coordinates to a location on the desktop image. */
+ private float[] mapScreenPointToImagePoint(float screenX, float screenY) {
+ float[] mappedPoints = {screenX, screenY};
+ Matrix screenToImage = new Matrix();
+ synchronized (mRenderData) {
+ mRenderData.transform.invert(screenToImage);
+ }
+ screenToImage.mapPoints(mappedPoints);
+
+ return mappedPoints;
+ }
+
/** Responds to touch events filtered by the gesture detectors. */
private class GestureListener extends GestureDetector.SimpleOnGestureListener
implements ScaleGestureDetector.OnScaleGestureListener,
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698