Calculate correct cull rect for SVG inline text boxes.

Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

Reland of http://crrev.com/2137753002 with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

BUG=627233
TBR=pdr

Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e
Cr-Commit-Position: refs/heads/master@{#405920}

[wkorman, 2016-07-15 21:31:00]

Description was changed from

==========
Reland of http://crrev.com/2137753002:

Updated test to approximate expected rects to allow for minor font metrics
differences across platforms. Notably, previous patch failed on Android
Nexus 4 due to 1 - 2 pixel deltas.

Original change description:

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

BUG=627233

Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
Cr-Commit-Position: refs/heads/master@{#405675}

patch from issue 2137753002 at patchset 40001
(http://crrev.com/2137753002#ps40001)
==========

to

==========
Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

BUG=627233

Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
Cr-Commit-Position: refs/heads/master@{#405675}

patch from issue 2137753002 at patchset 40001
(http://crrev.com/2137753002#ps40001)

Reland of http://crrev.com/2137753002, with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

TBR=pdr
==========

[wkorman, 2016-07-15 21:31:32]

Description was changed from

==========
Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

BUG=627233

Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
Cr-Commit-Position: refs/heads/master@{#405675}

patch from issue 2137753002 at patchset 40001
(http://crrev.com/2137753002#ps40001)

Reland of http://crrev.com/2137753002, with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

TBR=pdr
==========

to

==========
Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

BUG=627233

Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
Cr-Commit-Position: refs/heads/master@{#405675}

patch from issue 2137753002 at patchset 40001
(http://crrev.com/2137753002#ps40001)

Reland of http://crrev.com/2137753002, with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

TBR=pdr
==========

[wkorman, 2016-07-15 21:32:06]

Description was changed from

==========
Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

BUG=627233

Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
Cr-Commit-Position: refs/heads/master@{#405675}

patch from issue 2137753002 at patchset 40001
(http://crrev.com/2137753002#ps40001)

Reland of http://crrev.com/2137753002, with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

TBR=pdr
==========

to

==========
Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

Reland of http://crrev.com/2137753002 with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

BUG=627233
TBR=pdr
==========

[wkorman, 2016-07-15 21:36:28]

wkorman@chromium.org changed reviewers:
+ pdr@google.com

[wkorman, 2016-07-15 21:36:28]

Reland with test updated to approximate expected values.

[wkorman, 2016-07-15 21:36:31]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-07-15 21:36:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 21:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 21:51:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2016-07-15 21:57:12]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-07-15 21:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:11:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2016-07-15 22:51:57]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:52:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 00:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:14:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2016-07-16 00:50:28]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 02:07:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-16 02:09:24]

Description was changed from

==========
Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

Reland of http://crrev.com/2137753002 with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

BUG=627233
TBR=pdr
==========

to

==========
Calculate correct cull rect for SVG inline text boxes.

Cull rects were larger than needed when text was selected.

Identified while investigating test failure of:

svg/text/text-selection-align-06-b.svg

as part of http://crrev.com/2073563002 for crbug.com/616600, though
fixing these did not actually fix any issues for that patch or bug.

Reland of http://crrev.com/2137753002 with updated test to
approximate expected rects to allow for minor font metrics differences
across platforms. Notably, previous patch failed on Android Nexus 4
due to 1 - 2 pixel deltas.

BUG=627233
TBR=pdr

Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e
Cr-Commit-Position: refs/heads/master@{#405920}
==========

[commit-bot: I haz the power, 2016-07-16 02:09:25]

Patchset 4 (id:??) landed as
https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e
Cr-Commit-Position: refs/heads/master@{#405920}

[Benoit L, 2016-07-18 09:50:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2161573002/ by lizeb@chromium.org.

The reason for reverting is: Broke WebKit Android (Nexus4).

BUG=629023.