In GrShape detect that stroked axis-aligned lines are rrects.

In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002

Committed: https://skia.googlesource.com/skia/+/0ae36a2cebf35c68c3013383d3b640f70034be55

[bsalomon, 2016-07-15 16:28:16]

Description was changed from

==========
In GrShape detect that stroked axis-aligned lines are rrects.
==========

to

==========
In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002
==========

[bsalomon, 2016-07-15 18:07:33]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-07-15 18:48:38]

lgtm

https://codereview.chromium.org/2151313002/diff/40001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2151313002/diff/40001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:435: rect.fBottom = SkTMax(pts[0].fY, pts[1].fY);
Do we care about using a tolerance here ?

horizEq & vertEq ?

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:121: // If the bounds are empty, the path ought to be as
well.
add an isInverted predicate ?

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:515: 
geomeetry ?

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:714: static bool shape_known_not_to_have_joins(const
GrShape& shape) {
Don't we also know this for oval and simple RRect types ?

[bsalomon, 2016-07-18 14:02:41]

https://codereview.chromium.org/2151313002/diff/40001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2151313002/diff/40001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:435: rect.fBottom = SkTMax(pts[0].fY, pts[1].fY);
On 2016/07/15 18:48:38, robertphillips wrote:
> Do we care about using a tolerance here ?
Eh, I think eventually I'll make GrShape support having a matrix and we won't
care about axis alignment.

> 
> horizEq & vertEq ?

Yeah, the current names are backwards. Renamed to eqX and eqY

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:121: // If the bounds are empty, the path ought to be as
well.
On 2016/07/15 18:48:38, robertphillips wrote:
> add an isInverted predicate ?

I think I want to shy away from adding more methods on SkRect that have
semantics around what's considered empty.

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:515: 
On 2016/07/15 18:48:38, robertphillips wrote:
> geomeetry ?

Done.

https://codereview.chromium.org/2151313002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:714: static bool shape_known_not_to_have_joins(const
GrShape& shape) {
On 2016/07/15 18:48:38, robertphillips wrote:
> Don't we also know this for oval and simple RRect types ?

Yes, that will come in time, along with Dr. Rects.

[bsalomon, 2016-07-18 14:03:39]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-18 14:03:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2151313002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-07-18 14:03:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:09:01]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-07-18 14:15:49]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-18 14:15:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2151313002/#ps80001
(title: "Add accidentally delete semicolon back")

[commit-bot: I haz the power, 2016-07-18 14:16:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:31:18]

Description was changed from

==========
In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002
==========

to

==========
In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002

Committed:
https://skia.googlesource.com/skia/+/0ae36a2cebf35c68c3013383d3b640f70034be55
==========

[commit-bot: I haz the power, 2016-07-18 14:31:19]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0ae36a2cebf35c68c3013383d3b640f70034be55