Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol improvements Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
index cc2c8445437bb3eec770964e5faec14bef95b3f9..afa5138f6ec2455858813f2ba990304cd93b88c8 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
@@ -180,14 +180,17 @@ void V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback(const v8::Fun
}
V8DebuggerImpl* debugger = unwrapDebugger(info);
- debugger->client()->muteWarningsAndDeprecations();
+ int contextGroupId = V8DebuggerImpl::getGroupId(context);
+ if (contextGroupId)
+ debugger->client()->muteWarningsAndDeprecations(contextGroupId);
v8::MicrotasksScope microtasks(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::Local<v8::Value> result;
if (function->Call(context, receiver, argc, argv.get()).ToLocal(&result))
info.GetReturnValue().Set(result);
- debugger->client()->unmuteWarningsAndDeprecations();
+ if (contextGroupId)
+ debugger->client()->unmuteWarningsAndDeprecations(contextGroupId);
}
void V8InjectedScriptHost::bindCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

Powered by Google App Engine
This is Rietveld 408576698