Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2151253004: Revert of In rebaseline, include build number information with "test_prefix_list" dicts. (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #4 id:60001 of https://codereview.chromium.org/2144873004/ ) Reason for revert: Seems to be causing failures in webkit_python_tests on multiple bots (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653). Original issue's description: > In rebaseline, include build number information with "test_prefix_list" dicts. > > When rebaselining, the main argument passed to the rebaseline method is a "test_prefix_list", which is currently a dict mapping test prefixes to builder names to baseline file suffixes. > > If we want to change _suffixes_for_actual_failures to fetch actual failures for try jobs, then that method needs to know the build number as well. > > This CL would replace the builder in all "test_prefix_list" dicts with a Build object, which includes builder name and build number, but build number is optional. > > Planned follow-up: changing build_data() to use a method to fetch and cache results for particular builds, and change _suffixes_for_actual_failures fetch results for particular builds using that method as well. This would make the "skip_checking_actual_results" workaround unnecessary. I could also include that change in this CL. > > Committed: https://crrev.com/e5830ddcf7cc0fc87decede44a0a0baa4d5e8c61 > Cr-Commit-Position: refs/heads/master@{#405783} TBR=dpranke@chromium.org,wkorman@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/110c6f3a6dfa490acca83b2daa49615ee821ac8a Cr-Commit-Position: refs/heads/master@{#405804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -200 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 13 chunks +29 lines, -86 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py View 4 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 35 chunks +93 lines, -94 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wjmaclean
Created Revert of In rebaseline, include build number information with "test_prefix_list" dicts.
4 years, 5 months ago (2016-07-15 18:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151253004/1
4 years, 5 months ago (2016-07-15 18:50:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:51:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/110c6f3a6dfa490acca83b2daa49615ee821ac8a Cr-Commit-Position: refs/heads/master@{#405804}
4 years, 5 months ago (2016-07-15 18:53:30 UTC) #6
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-15 18:54:46 UTC) #7
qyearsley
4 years, 5 months ago (2016-07-15 20:34:45 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2153973002/ by qyearsley@chromium.org.

The reason for reverting is: Making a reland CL to investigate and try to
reproduce the unit test failures (e.g.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/build...).

Powered by Google App Engine
This is Rietveld 408576698