DescriptionRevert of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #4 id:60001 of https://codereview.chromium.org/2144873004/ )
Reason for revert:
Seems to be causing failures in webkit_python_tests on multiple bots (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653).
Original issue's description:
> In rebaseline, include build number information with "test_prefix_list" dicts.
>
> When rebaselining, the main argument passed to the rebaseline method is a "test_prefix_list", which is currently a dict mapping test prefixes to builder names to baseline file suffixes.
>
> If we want to change _suffixes_for_actual_failures to fetch actual failures for try jobs, then that method needs to know the build number as well.
>
> This CL would replace the builder in all "test_prefix_list" dicts with a Build object, which includes builder name and build number, but build number is optional.
>
> Planned follow-up: changing build_data() to use a method to fetch and cache results for particular builds, and change _suffixes_for_actual_failures fetch results for particular builds using that method as well. This would make the "skip_checking_actual_results" workaround unnecessary. I could also include that change in this CL.
>
> Committed: https://crrev.com/e5830ddcf7cc0fc87decede44a0a0baa4d5e8c61
> Cr-Commit-Position: refs/heads/master@{#405783}
TBR=dpranke@chromium.org,wkorman@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/110c6f3a6dfa490acca83b2daa49615ee821ac8a
Cr-Commit-Position: refs/heads/master@{#405804}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|