Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2151223002: [turbofan] Add re-typing for PlainPrimitiveToNumber during representation inference. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add re-typing for PlainPrimitiveToNumber during representation inference. This makes sure that the uses of PlainPrimitiveToNumber get a more precise type (so that the uses know how to interpret the output representation). BUG=chromium:628516 Committed: https://crrev.com/9f859c66a1caa1dfaa5874196c3d65ee90edfcf2 Cr-Commit-Position: refs/heads/master@{#37792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-628516.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 5 months ago (2016-07-15 09:58:29 UTC) #4
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-15 10:34:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151223002/1
4 years, 5 months ago (2016-07-15 10:34:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 10:37:22 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 10:37:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f859c66a1caa1dfaa5874196c3d65ee90edfcf2
Cr-Commit-Position: refs/heads/master@{#37792}

Powered by Google App Engine
This is Rietveld 408576698