Chromium Code Reviews
DescriptionRevert of Calculate correct cull rect for SVG inline text boxes. (patchset #3 id:40001 of https://codereview.chromium.org/2137753002/ )
Reason for revert:
Most likely breaks:
SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode
SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/50365
Original issue's description:
> Calculate correct cull rect for SVG inline text boxes.
>
> Cull rects were larger than needed when text was selected.
>
> Identified while investigating test failure of:
>
> svg/text/text-selection-align-06-b.svg
>
> as part of http://crrev.com/2073563002 for crbug.com/616600, though
> fixing these did not actually fix any issues for that patch or bug.
>
> BUG=627233
>
> Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca
> Cr-Commit-Position: refs/heads/master@{#405675}
TBR=pdr@chromium.org,wkorman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627233
Committed: https://crrev.com/b0b85266865004e7a708a7a5e7e272a0b8784ef2
Cr-Commit-Position: refs/heads/master@{#405722}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||