Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2151203002: Revert of Calculate correct cull rect for SVG inline text boxes. (Closed)

Created:
4 years, 5 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 5 months ago
Reviewers:
pdr., wkorman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Calculate correct cull rect for SVG inline text boxes. (patchset #3 id:40001 of https://codereview.chromium.org/2137753002/ ) Reason for revert: Most likely breaks: SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/50365 Original issue's description: > Calculate correct cull rect for SVG inline text boxes. > > Cull rects were larger than needed when text was selected. > > Identified while investigating test failure of: > > svg/text/text-selection-align-06-b.svg > > as part of http://crrev.com/2073563002 for crbug.com/616600, though > fixing these did not actually fix any issues for that patch or bug. > > BUG=627233 > > Committed: https://crrev.com/3f0f1c6a0edb31e2ec3ce4dbb21acc83301982ca > Cr-Commit-Position: refs/heads/master@{#405675} TBR=pdr@chromium.org,wkorman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627233 Committed: https://crrev.com/b0b85266865004e7a708a7a5e7e272a0b8784ef2 Cr-Commit-Position: refs/heads/master@{#405722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -126 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 chunk +0 lines, -123 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Calculate correct cull rect for SVG inline text boxes.
4 years, 5 months ago (2016-07-15 08:20:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151203002/1
4 years, 5 months ago (2016-07-15 08:21:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 08:21:50 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 08:23:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0b85266865004e7a708a7a5e7e272a0b8784ef2
Cr-Commit-Position: refs/heads/master@{#405722}

Powered by Google App Engine
This is Rietveld 408576698