Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 21512002: Reenable tests that need to access the default timezone. (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reenable tests that need to access the default timezone. It's now available via builtins. BUG=v8:2475 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M test/intl/break-iterator/default-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/break-iterator/wellformed-unsupported-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/collator/default-locale.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/intl/collator/wellformed-unsupported-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/date-format/default-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/date-format/wellformed-unsupported-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/intl.status View 1 chunk +1 line, -9 lines 0 comments Download
M test/intl/number-format/default-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/number-format/wellformed-unsupported-locale.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 09:18:07 UTC) #1
Michael Starzinger
LGTM. The bug number in the CL description seems to be off though.
7 years, 4 months ago (2013-08-01 11:15:04 UTC) #2
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 19:43:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698