Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2151193002: Revert of PVer4: Keep track of the smallest hashes not their sizes. Replace counters with iterators. (Closed)

Created:
4 years, 5 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Scott Hess - ex-Googler, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@01_read_map_from_disk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PVer4: Keep track of the smallest hashes not their sizes. Replace counters with iterators. (patchset #6 id:100001 of https://codereview.chromium.org/2145163003/ ) Reason for revert: Breaks V4StoreTest tests on Win7 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F50624%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests_on_Windows-7-SP1%2F0%2Fstdout# Original issue's description: > PVer4: Keep track of the smallest hashes not their sizes. > Also, replace counters with iterators to avoid multiplications > > BUG=543161 > > Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3 > Cr-Commit-Position: refs/heads/master@{#405662} TBR=nparker@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/e63d7263dc1757009b7b6c12e3e14c3853e19ea3 Cr-Commit-Position: refs/heads/master@{#405718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -96 lines) Patch
M components/safe_browsing_db/v4_store.h View 3 chunks +22 lines, -16 lines 0 comments Download
M components/safe_browsing_db/v4_store.cc View 3 chunks +77 lines, -61 lines 0 comments Download
M components/safe_browsing_db/v4_store_unittest.cc View 1 chunk +36 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
henrika (OOO until Aug 14)
Created Revert of PVer4: Keep track of the smallest hashes not their sizes. Replace counters ...
4 years, 5 months ago (2016-07-15 07:53:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151193002/1
4 years, 5 months ago (2016-07-15 07:53:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 07:54:19 UTC) #5
henrika (OOO until Aug 14)
Seems like these tests are failing failures: V4StoreTest.TestMergeUpdatesAdditionsMapRunsOutFirst V4StoreTest.TestMergeUpdatesWithSameSizesInEachMap V4StoreTest.TestMergeUpdatesOldMapRunsOutFirst V4StoreTest.TestMergeUpdatesWithDifferentSizesInEachMap
4 years, 5 months ago (2016-07-15 07:54:19 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 07:54:26 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 07:56:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e63d7263dc1757009b7b6c12e3e14c3853e19ea3
Cr-Commit-Position: refs/heads/master@{#405718}

Powered by Google App Engine
This is Rietveld 408576698