Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4084)

Unified Diff: chrome/browser/chromeos/login/app_launch_controller.cc

Issue 2151113002: kiosk: Show network config UI after profile load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a state/message while waiting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/app_launch_controller.cc
diff --git a/chrome/browser/chromeos/login/app_launch_controller.cc b/chrome/browser/chromeos/login/app_launch_controller.cc
index 54c4f0c4b80b55c9ee255cef07426ba8622a2d6f..33d8749ae362db79c108363db73445d8d068f92d 100644
--- a/chrome/browser/chromeos/login/app_launch_controller.cc
+++ b/chrome/browser/chromeos/login/app_launch_controller.cc
@@ -235,7 +235,7 @@ void AppLaunchController::OnConfigureNetwork() {
}
void AppLaunchController::OnOwnerSigninSuccess() {
- app_launch_splash_screen_actor_->ShowNetworkConfigureUI();
+ ShowNetworkConfigureUIWhenReady();
signin_screen_.reset();
}
@@ -260,10 +260,13 @@ void AppLaunchController::OnCancelAppLaunch() {
void AppLaunchController::OnNetworkConfigRequested(bool requested) {
network_config_requested_ = requested;
- if (requested)
+ if (requested) {
MaybeShowNetworkConfigureUI();
- else
+ } else {
+ app_launch_splash_screen_actor_->UpdateAppLaunchState(
+ AppLaunchSplashScreenActor::APP_LAUNCH_STATE_PREPARING_NETWORK);
startup_app_launcher_->RestartLauncher();
+ }
}
void AppLaunchController::OnNetworkStateChanged(bool online) {
@@ -287,6 +290,9 @@ void AppLaunchController::OnProfileLoaded(Profile* profile) {
startup_app_launcher_.reset(
new StartupAppLauncher(profile_, app_id_, diagnostic_mode_, this));
startup_app_launcher_->Initialize();
+
+ if (show_network_config_ui_after_profile_load_)
+ ShowNetworkConfigureUIWhenReady();
}
void AppLaunchController::OnProfileLoadFailed(
@@ -360,8 +366,7 @@ void AppLaunchController::MaybeShowNetworkConfigureUI() {
else
app_launch_splash_screen_actor_->ToggleNetworkConfig(true);
} else {
- showing_network_dialog_ = true;
- app_launch_splash_screen_actor_->ShowNetworkConfigureUI();
+ ShowNetworkConfigureUIWhenReady();
}
} else {
app_launch_splash_screen_actor_->UpdateAppLaunchState(
@@ -369,6 +374,20 @@ void AppLaunchController::MaybeShowNetworkConfigureUI() {
}
}
+void AppLaunchController::ShowNetworkConfigureUIWhenReady() {
+ if (!profile_) {
+ show_network_config_ui_after_profile_load_ = true;
+ app_launch_splash_screen_actor_->UpdateAppLaunchState(
+ AppLaunchSplashScreenActor::
+ APP_LAUNCH_STATE_SHOWING_NETWORK_CONFIGURE_UI);
+ return;
+ }
+
+ show_network_config_ui_after_profile_load_ = false;
+ showing_network_dialog_ = true;
+ app_launch_splash_screen_actor_->ShowNetworkConfigureUI();
+}
+
void AppLaunchController::InitializeNetwork() {
// Show the network configuration dialog if network is not initialized
// after a brief wait time.

Powered by Google App Engine
This is Rietveld 408576698