Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2151113002: kiosk: Show network config UI after profile load (Closed)

Created:
4 years, 5 months ago by xiyuan
Modified:
4 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Show network config UI after profile load BUG=628379 Committed: https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660 Cr-Commit-Position: refs/heads/master@{#406019}

Patch Set 1 #

Patch Set 2 : add a state/message while waiting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 5 chunks +24 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/app_launch_splash_screen_actor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
xiyuan
4 years, 5 months ago (2016-07-14 23:08:48 UTC) #4
jennyz
lgtm
4 years, 5 months ago (2016-07-15 20:47:25 UTC) #7
xiyuan
Added a state and message so that user is aware that the network config request ...
4 years, 5 months ago (2016-07-18 16:21:01 UTC) #10
jennyz
lgtm
4 years, 5 months ago (2016-07-18 16:26:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151113002/20001
4 years, 5 months ago (2016-07-18 17:03:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 17:09:48 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 17:10:06 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:12:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660
Cr-Commit-Position: refs/heads/master@{#406019}

Powered by Google App Engine
This is Rietveld 408576698